Skip to content

feat(ffi) Add create poll API #2391

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 12 commits into from
Aug 10, 2023
Merged

feat(ffi) Add create poll API #2391

merged 12 commits into from
Aug 10, 2023

Conversation

alfogrillo
Copy link
Contributor

Fix #2388

Body example forPUT _matrix/client/v3/rooms/{room-id}/send/org.matrix.msc3381.poll.start

{
  "org.matrix.msc1767.text": "Do you like polls?\n1. Yes\n2. No\n3. Maybe",
  "org.matrix.msc3381.poll.start": {
    "answers": [
      {
        "id": "0",
        "org.matrix.msc1767.text": "Yes"
      },
      {
        "id": "1",
        "org.matrix.msc1767.text": "No"
      },
      {
        "id": "2",
        "org.matrix.msc1767.text": "Maybe"
      }
    ],
    "kind": "org.matrix.msc3381.poll.disclosed",
    "max_selections": 2,
    "question": {
      "org.matrix.msc1767.text": "Do you like polls?"
    }
  }
}

@alfogrillo alfogrillo force-pushed the alfogrillo/send_polls branch from c5a62e4 to d6fca12 Compare August 9, 2023 09:10
@alfogrillo alfogrillo changed the base branch from julioromano/polls to main August 9, 2023 09:10
@alfogrillo alfogrillo marked this pull request as ready for review August 9, 2023 09:11
@alfogrillo alfogrillo requested a review from a team as a code owner August 9, 2023 09:11
@alfogrillo alfogrillo requested review from jplatte and removed request for a team August 9, 2023 09:11
Copy link
Contributor

@julioromano julioromano left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM for what it's worth :D

@codecov
Copy link

codecov bot commented Aug 9, 2023

Codecov Report

Patch coverage has no change and project coverage change: +0.01% 🎉

Comparison is base (3d3021e) 77.84% compared to head (96e4e22) 77.85%.
Report is 33 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2391      +/-   ##
==========================================
+ Coverage   77.84%   77.85%   +0.01%     
==========================================
  Files         176      176              
  Lines       18698    18698              
==========================================
+ Hits        14555    14558       +3     
+ Misses       4143     4140       -3     

see 1 file with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@alfogrillo alfogrillo force-pushed the alfogrillo/send_polls branch from 482d690 to b0c16c4 Compare August 9, 2023 11:57
@alfogrillo alfogrillo changed the title Add create poll API to UniFFI feat(ffi) Add create poll API Aug 9, 2023
@jplatte jplatte enabled auto-merge (squash) August 10, 2023 15:10
@jplatte jplatte disabled auto-merge August 10, 2023 15:10
@jplatte jplatte enabled auto-merge (squash) August 10, 2023 15:10
@jplatte jplatte merged commit 364a4ae into main Aug 10, 2023
@jplatte jplatte deleted the alfogrillo/send_polls branch August 10, 2023 15:38
julioromano pushed a commit to element-hq/element-x-android that referenced this pull request Aug 24, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add a function to send "poll.start" events
3 participants