Skip to content

Surface send poll start API from rust sdk #1140

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Aug 24, 2023
Merged

Surface send poll start API from rust sdk #1140

merged 1 commit into from
Aug 24, 2023

Conversation

julioromano
Copy link

@julioromano julioromano self-assigned this Aug 24, 2023
@julioromano julioromano requested a review from a team as a code owner August 24, 2023 08:51
@julioromano julioromano requested review from jmartinesp and removed request for a team August 24, 2023 08:51
@github-actions
Copy link
Contributor

📱 Scan the QR code below to install the build (arm64 only) for this PR.
QR code
If you can't scan the QR code you can install the build via this link: https://i.diawi.com/JUcimC

@codecov
Copy link

codecov bot commented Aug 24, 2023 •
edited
Loading

Codecov Report

Patch coverage: 11.11% and project coverage change: -0.05% ⚠️

Comparison is base (648e2c3) 57.11% compared to head (96e5151) 57.06%.

Additional details and impacted files 
@@             Coverage Diff             @@
##           develop    #1140      +/-   ##
===========================================
- Coverage    57.11%   57.06%   -0.05%     
===========================================
  Files         1022     1022              
  Lines        26237    26263      +26     
  Branches      5305     5306       +1     
===========================================
+ Hits         14985    14988       +3     
- Misses        8943     8966      +23     
  Partials      2309     2309
Files Changed Coverage Δ
...nt/android/libraries/matrix/api/room/MatrixRoom.kt 33.33% <ø> (ø)
...ent/android/libraries/matrix/impl/poll/PollKind.kt 0.00% <0.00%> (ø)
...droid/libraries/matrix/impl/room/RustMatrixRoom.kt 0.00% <0.00%> (ø)
...droid/libraries/matrix/test/room/FakeMatrixRoom.kt 85.22% <23.07%> (-4.96%) ⬇️

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

0.0% 0.0% Coverage
0.0% 0.0% Duplication

jmartinesp
jmartinesp approved these changes Aug 24, 2023
View reviewed changes
Copy link
Member

@jmartinesp jmartinesp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@julioromano julioromano merged commit 9fb0216 into develop Aug 24, 2023
@julioromano julioromano deleted the julioromano/create_poll_api branch August 24, 2023 09:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jmartinesp jmartinesp jmartinesp approved these changes

Assignees

@julioromano julioromano

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Surface send poll start API from rust sdk to Android
2 participants
@julioromano @jmartinesp