Skip to content
This repository was archived by the owner on Sep 11, 2024. It is now read-only.

Share history in rooms in spaces by default #11446

Closed
wants to merge 1 commit into from
Closed

Share history in rooms in spaces by default #11446

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/createRoom.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -233,7 +233,7 @@ export default async function createRoom(client: MatrixClient, opts: IOpts): Pro
createOpts.initial_state.push(makeSpaceParentEvent(opts.parentSpace, true));
if (!opts.historyVisibility) {
opts.historyVisibility =
createOpts.preset === Preset.PublicChat ? HistoryVisibility.WorldReadable : HistoryVisibility.Invited;
createOpts.preset === Preset.PublicChat ? HistoryVisibility.WorldReadable : HistoryVisibility.Shared;
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Setting aside for now whether this is a valid change (see element-hq/element-meta#377 (comment)):

If Element-Android and Element-iOS just follow the server's defaults in this situation, should we not also do so here?

}

if (opts.joinRule === JoinRule.Restricted) {
Expand Down