This repository was archived by the owner on Sep 11, 2024. It is now read-only.
Share history in rooms in spaces by default #11446
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
Z-Community-PR
richvdh
added
the
T-Enhancement
richvdh
suggested changes
Aug 22, 2023
| @@ -233,7 +233,7 @@ export default async function createRoom(client: MatrixClient, opts: IOpts): Pro | |||
| createOpts.initial_state.push(makeSpaceParentEvent(opts.parentSpace, true)); | |||
| if (!opts.historyVisibility) { | |||
| opts.historyVisibility = | |||
| createOpts.preset === Preset.PublicChat ? HistoryVisibility.WorldReadable : HistoryVisibility.Invited; | |||
| createOpts.preset === Preset.PublicChat ? HistoryVisibility.WorldReadable : HistoryVisibility.Shared; | |||
There was a problem hiding this comment.
Setting aside for now whether this is a valid change (see element-hq/element-meta#377 (comment)):
If Element-Android and Element-iOS just follow the server's defaults in this situation, should we not also do so here?
|
@gabrc52 I'm assuming you're no longer interested in working on this, so am closing it accordingly. We can reopen if you're still interested in it. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Gabriel Rodríguez [email protected]
Fixes element-hq/element-meta#377. Fixes element-hq/element-meta#1999. Both Element iOS and Element Android already do this by default (which seems to be inherited from the homeserver's behavior). Only Element Web has inconsistent behavior. This PR is opinionated in deliberately choosing the same behavior as on mobile.
Checklist
Notes: history_visibility on rooms in spaces is now
sharedby defaultelement-web notes: New rooms created in spaces have their future history shared to all room members
Here's what your changelog entry will look like:
✨ Features
sharedby default (#11446). Fixes Consider changing the default history visibility settings for space-accessible encrypted rooms element-hq/element-meta#377. Contributed by @gabrc52.