Read site labels from cif file #3136
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Revise implementation to fix test failures
…et(struct.site_properties["labels"])) == 4
janosh
added
enhancement
|
Thanks @stefsmeets! 👍 |
|
Sorry, was a bit trigger happy on the merge. Tests didn't run on account of this change 1975b921f I just reverted. Could you do me a favor and take a look at the failing tests? |
4 tasks
janosh
added a commit
that referenced
this pull request
Jul 11, 2023
* Store site label in `site_properties` Revise implementation to fix test failures * Add test * pre-commit auto-fixes * rename single-letter vars, use snake_case * assert len(struct.site_properties["labels"]) == len(struct) and len(set(struct.site_properties["labels"])) == 4 --------- Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com> Co-authored-by: Janosh Riebesell <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Major changes:
Structure.site_properties.Closes #3135
Checklist
ruff.mypy.duecredit@due.dcitedecorators to reference relevant papers by DOI (example)Tip: Install
pre-commithooks to auto-check types and linting before every commit: