revert to if: github.repository == 'materialsproject/pymatgen' to prevent running tests on forks

Author: janosh

.github/workflows/test.yml

@@ -23,7 +23,7 @@ permissions:
 jobs:
   pytest:
     # prevent this action from running on forks
-    if: ${{ !github.event.pull_request.head.repo.fork }}
+    if: github.repository == 'materialsproject/pymatgen'
     strategy:
       fail-fast: false
       matrix:

.pre-commit-config.yaml

@@ -8,7 +8,7 @@ ci:
 
 repos:
   - repo: https://github.com/astral-sh/ruff-pre-commit
-    rev: v0.0.276
+    rev: v0.0.277
     hooks:
       - id: ruff
         args: [--fix]
@@ -27,12 +27,12 @@ repos:
       - id: black
 
   - repo: https://github.com/pre-commit/mirrors-mypy
-    rev: v1.4.0
+    rev: v1.4.1
     hooks:
       - id: mypy
 
   - repo: https://github.com/codespell-project/codespell
-    rev: v2.2.4
+    rev: v2.2.5
     hooks:
       - id: codespell
         stages: [commit, commit-msg]

pymatgen/analysis/elasticity/elastic.py

@@ -979,16 +979,14 @@ def generate_pseudo(strain_states, order=3):
         order (int): order of pseudo-inverse to calculate
 
     Returns:
-        mis: pseudo inverses for each order tensor, these can
-            be multiplied by the central difference derivative
-            of the stress with respect to the strain state
-        absent_syms: symbols of the tensor absent from the PI
-            expression
+        pseudo_inverses: for each order tensor, these can be multiplied by the central
+            difference derivative of the stress with respect to the strain state
+        absent_syms: symbols of the tensor absent from the PI expression
     """
     s = sp.Symbol("s")
     nstates = len(strain_states)
     ni = np.array(strain_states) * s
-    mis, absent_syms = [], []
+    pseudo_inverses, absent_symbols = [], []
     for degree in range(2, order + 1):
         cvec, carr = get_symbol_list(degree)
         sarr = np.zeros((nstates, 6), dtype=object)
@@ -1000,13 +998,13 @@ def generate_pseudo(strain_states, order=3):
             exps /= math.factorial(degree - 1)
             sarr[n] = [sp.diff(exp, s, degree - 1) for exp in exps]
         svec = sarr.ravel()
-        present_syms = set.union(*(exp.atoms(sp.Symbol) for exp in svec))
-        absent_syms += [set(cvec) - present_syms]
+        present_symbols = set.union(*(exp.atoms(sp.Symbol) for exp in svec))
+        absent_symbols += [set(cvec) - present_symbols]
         m = np.zeros((6 * nstates, len(cvec)))
         for n, c in enumerate(cvec):
             m[:, n] = v_diff(svec, c)
-        mis.append(np.linalg.pinv(m))
-    return mis, absent_syms
+        pseudo_inverses.append(np.linalg.pinv(m))
+    return pseudo_inverses, absent_symbols
 
 
 def get_symbol_list(rank, dim=6):