Document rare structure dependence of MaterialsProjectCompatibility corrections #2731
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
janosh
commented
Nov 9, 2022
|
Thanks @janosh ! There appear to be a bunch of linting changes in here in other parts of pymatgen. Not sure if that was intentional or not; no objections, just calling your attention to it. |
lbluque
pushed a commit
to lbluque/pymatgen
that referenced
this pull request
Nov 11, 2022
…orrections (materialsproject#2731) * str refactors * document rare structure dependence of MPCompat energy corrections * incorporate feedback from @rkingsbury
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #2730.
Relevant commit in this PR is d1f6f92.