Skip to content

Commit d1f6f92

Browse files
committed
document rare structure dependence of MPCompat energy corrections
1 parent 9458db0 commit d1f6f92

File tree

1 file changed

+12
-6
lines changed

1 file changed

+12
-6
lines changed

pymatgen/entries/compatibility.py

Lines changed: 12 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -818,14 +818,20 @@ def __init__(
818818
@cached_class
819819
class MaterialsProject2020Compatibility(Compatibility):
820820
"""
821-
This class implements the Materials Project 2020 energy correction scheme,
822-
which incorporates uncertainty quantification and allows for mixing of GGA
823-
and GGA+U entries (see References).
821+
This class implements the Materials Project 2020 energy correction scheme, which
822+
incorporates uncertainty quantification and allows for mixing of GGA and GGA+U entries
823+
(see References).
824824
825825
Note that this scheme should only be applied to VASP calculations that use the
826-
Materials Project input set parameters (see pymatgen.io.vasp.sets.MPRelaxSet).
827-
Using this compatibility scheme on calculations with different parameters is not
828-
valid.
826+
Materials Project input set parameters (see pymatgen.io.vasp.sets.MPRelaxSet). Using
827+
this compatibility scheme on calculations with different parameters is not valid.
828+
829+
Note: While the correction scheme is largely composition-based, corrections applied to
830+
ComputedEntry and ComputedStructureEntry differ in rare cases. This is because if
831+
entry.data['oxidation_states'] is not set explicitly, the atomic distance information
832+
in the structure will be used to classify O and S anions as superoxide/peroxide/oxide
833+
and sulfide/polysulfide, resp. If you want the most accurate corrections possible,
834+
always pass ComputedStructureEntries (unless you have pre-defined oxidation states).
829835
"""
830836

831837
def __init__(

0 commit comments

Comments
 (0)