-
Notifications
You must be signed in to change notification settings - Fork 265
security vulnerability? due to old [email protected] (and [email protected]) dependency #346
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Comments
More information on the security vulnerability in old versions of hoek: For what it's worth, the patch was also backported to hoek 4.2.1. |
This is now also being reported by nsp, https://nodesecurity.io/advisories/566 |
Or upgrade to [email protected] which have the patched version of hoek in the packge.json |
@springmeyer any news about dependency updates? |
Hi Could you please update hawk to latest version. Thank you! |
That won't fix things, as there is Request has several PRs to fix that, but that didn't happen yet. Perhaps migrate away from |
@SebastianSchmidt request itself isn't updated yet, that won't help. |
@SebastianSchmidt Ah, looks like I was indeed wrong, current '5.0.0': '2017-09-26T04:22:40.507Z',
'5.0.1': '2017-10-26T08:22:11.034Z',
'5.0.2': '2017-11-03T09:12:15.703Z',
'5.0.3': '2018-02-06T17:55:50.172Z',
'4.2.1': '2018-02-15T16:47:47.274Z' |
Fixed by merging #347 |
This patch removes the explicit dependency on hawk, and upgrades request to the newest version. It also removes node 0.10 from the testing grid, as this version has been EOL'd by the node foundation, and doesn't support es6 syntax used in the newer introduced dependencies. https://nodesecurity.io/advisories/566 https://hackerone.com/reports/310439 https://github.com/nodejs/Release Closes mapbox#346
in our project, snyk recently started complaining that we have a dependency with a known security vulnerability. It complains about
[email protected]
which is required by[email protected]
which is required by the latest version ofnode-pre-gyp
the latest version of
hoek
(version 5.0.3) fixed the vulnerability. Butnode-pre-gyp
has locked the version ofhawk
to 3.1.3 while the latest version ofhawk
is 7.0.7. Using such an old version ofhawk
also uses a very old version ofhoek
.Would it be easy to upgrade to the latest version of
hawk
so we get the latest version ofhoek
without the vulnerability?More info about the (low prio) vulnerability in
hoek
can be found at https://snyk.io/vuln/npm:hoek:20180212The text was updated successfully, but these errors were encountered: