Skip to content

Security vulnerability through outdated version of hoek #950

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
SebastianSchmidt opened this issue Mar 10, 2018 · 2 comments
Closed

Security vulnerability through outdated version of hoek #950

SebastianSchmidt opened this issue Mar 10, 2018 · 2 comments

Comments

@SebastianSchmidt
Copy link
Contributor

node-sqlite3 is dependent on an outdated version of hoek (through the node-pre-gyp package), which has a security vulnerability.

[email protected] › [email protected] › [email protected] › [email protected]
[email protected] › [email protected] › [email protected] › [email protected] › [email protected]
[email protected] › [email protected] › [email protected] › [email protected] › [email protected] › [email protected]
[email protected] › [email protected] › [email protected] › [email protected] › [email protected]
[email protected] › [email protected] › [email protected] › [email protected] › [email protected] › [email protected]
[email protected] › [email protected] › [email protected] › [email protected] › [email protected]
[email protected] › [email protected] › [email protected] › [email protected] › [email protected] › [email protected] › [email protected]
[email protected] › [email protected] › [email protected] › [email protected] › [email protected] › [email protected]

The latest version of node-pre-gyp uses a version of hoek that fixes the vulnerability. The latest version of node-pre-gyp (0.7.0) no longer supports Node 0.10 and 0.14. However, Node 0.10 and 0.14 are no longer supported, so I think it's justifiable if node-sqlite3 also does not support these versions.
@SebastianSchmidt SebastianSchmidt mentioned this issue Mar 10, 2018
Closed
4 tasks
@gms1 gms1 mentioned this issue Mar 11, 2018
Closed
@springmeyer
Copy link
Contributor

@SebastianSchmidt would you be up for creating a PR upgrading node-pre-gyp?

@SebastianSchmidt
Copy link
Contributor Author

@springmeyer Yes, I'll take care of it.

@SebastianSchmidt SebastianSchmidt mentioned this issue Mar 14, 2018
Merged
kirrg001 added a commit to TryGhost/knex-migrator that referenced this issue Mar 16, 2018
@kirrg001
Bump sqlite3 to version ^4.0.0
a2d90ee 
no issue

- see TryGhost/node-sqlite3#950
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@springmeyer @SebastianSchmidt