Skip to content

Handle removed is_rgb from fmt 11.2.0 #3998

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 30, 2025
Merged

Conversation

Hind-M
Copy link
Member

@Hind-M Hind-M commented Jun 27, 2025

Description

Fix #3958

Type of Change

  • Bugfix
  • Feature / enhancement
  • CI / Documentation
  • Maintenance

Checklist

  • My code follows the general style and conventions of the codebase, ensuring consistency
  • I have performed a self-review of my code
  • I have commented my code, particularly in hard-to-understand areas
  • My changes generate no new warnings
  • I have run pre-commit run --all locally in the source folder and confirmed that there are no linter errors.
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing tests pass locally with my changes

@github-actions github-actions bot added the release::maintenance For PRs related to maintenance label Jun 27, 2025
Copy link

codecov bot commented Jun 27, 2025

Codecov Report

Attention: Patch coverage is 0% with 4 lines in your changes missing coverage. Please review.

Project coverage is 63.81%. Comparing base (6adb2ea) to head (198fc53).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
libmambapy/src/libmambapy/bindings/utils.cpp 0.00% 4 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3998      +/-   ##
==========================================
- Coverage   63.81%   63.81%   -0.01%     
==========================================
  Files         303      303              
  Lines       38673    38675       +2     
  Branches     2865     2858       -7     
==========================================
+ Hits        24681    24682       +1     
- Misses      13925    13926       +1     
  Partials       67       67              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@Hind-M Hind-M marked this pull request as ready for review June 27, 2025 14:36
Copy link
Member

@jjerphan jjerphan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thank you, @Hind-M.

Side-note: we could ask to merge conda-forge/fmt-feedstock#66 to test the other case.

@JohanMabille JohanMabille merged commit b3d580e into mamba-org:main Jun 30, 2025
56 of 58 checks passed
@Hind-M Hind-M deleted the fmt branch June 30, 2025 09:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
release::maintenance For PRs related to maintenance
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Does not compile with fmt 11.2
3 participants