Skip to content

fmt v11.2.0 #66

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Jun 30, 2025
Merged

Conversation

regro-cf-autotick-bot
Copy link
Contributor

It is very likely that the current package version for this feedstock is out of date.

Checklist before merging this PR:

  • Dependencies have been updated if changed: see upstream
  • Tests have passed
  • Updated license if changed and license_file is packaged

Information about this PR:

  1. Feel free to push to the bot's branch to update this PR if needed.
  2. The bot will almost always only open one PR per version.
  3. The bot will stop issuing PRs if more than 3 version bump PRs generated by the bot are open. If you don't want to package a particular version please close the PR.
  4. If you want these PRs to be merged automatically, make an issue with @conda-forge-admin,please add bot automerge in the title and merge the resulting PR. This command will add our bot automerge feature to your feedstock.
  5. If this PR was opened in error or needs to be updated please add the bot-rerun label to this PR. The bot will close this PR and schedule another one. If you do not have permissions to add this label, you can use the phrase @conda-forge-admin, please rerun bot in a PR comment to have the conda-forge-admin add it for you.

This PR was created by the regro-cf-autotick-bot. The regro-cf-autotick-bot is a service to automatically track the dependency graph, migrate packages, and propose package version updates for conda-forge. Feel free to drop us a line if there are any issues! This PR was generated by https://github.com/regro/cf-scripts/actions/runs/14814842107 - please use this URL for debugging.

@conda-forge-admin
Copy link
Contributor

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipe/meta.yaml) and found it was in an excellent condition.

Copy link
Member

@jjerphan jjerphan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

FYI, this version of fmt comes with at least an API break, see fmtlib/fmt#4466.

Do you think version can be released?

@jjerphan
Copy link
Member

@conda-forge-admin, please rerender

@h-vetinari
Copy link
Member

FYI, this version of fmt comes with at least an API break, see fmtlib/fmt#4466.

Do you think version can be released?

Given that we switched to minor-level pinning, this should be fine.

@h-vetinari
Copy link
Member

Do you think version can be released?

It would be great if we could draw down the 11.1 migration, but since this has been open for ~months, I guess we can just focus that effort on 11.2

@h-vetinari h-vetinari merged commit d1dc552 into conda-forge:main Jun 30, 2025
10 checks passed
@regro-cf-autotick-bot regro-cf-autotick-bot deleted the 11.2.0_hfba8a1 branch June 30, 2025 09:48
@jjerphan
Copy link
Member

jjerphan commented Jun 30, 2025

Note that in environments where spdlog is installed, updating fmt to this version downgrade spdlog to its latest build not depending on fmt.

mamba create -n fmt_spdlog spdlog fmt==11.1.4
mamba update -n fmt_spdlog fmt
  Package         Version  Build       Channel           Size
───────────────────────────────────────────────────────────────
  Install:
───────────────────────────────────────────────────────────────

  + libgcc-ng      15.1.0  h69a702a_3  conda-forge       29kB
  + libstdcxx-ng   15.1.0  h4852527_3  conda-forge       29kB

  Upgrade:
───────────────────────────────────────────────────────────────

  - fmt            11.1.4  h07f6e7f_1  conda-forge     Cached
  + fmt            11.2.0  h07f6e7f_0  conda-forge      193kB

  Downgrade:
───────────────────────────────────────────────────────────────

  - spdlog         1.15.3  h10b92b3_0  conda-forge     Cached
  + spdlog         1.10.0  h924138e_0  conda-forge      356kB

  Summary:

  Install: 2 packages
  Upgrade: 1 packages
  Downgrade: 1 packages

  Total download: 607kB

───────────────────────────────────────────────────────────────

Would the best fix be to repodata-patch the builds before spdlog==1.10.0=h*_0 (included) so that they cannot be installed with fmt? E.g.:

# See: https://github.com/conda-forge/fmt-feedstock/pull/66#issuecomment-3019364053
if:
  name: spdlog
  # Timestamp of spdlog 1.10.0 h*_1
  timestamp_lt: 1666388269911
then:
  - add_constrains:
      - "fmt <0.0a0"

@h-vetinari
Copy link
Member

If old spdlog didn't depend on fmt, then I don't think it's the right approach to put in a constraint. The right fix here is to rebuild spdlog for fmt 11.2

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants