Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Web] Improve clarity of LDAP SSL/TLS settings #6460

Merged
merged 3 commits into from
Apr 7, 2025

Conversation

FreddleSpl0it
Copy link
Collaborator

Contribution Guidelines

What does this PR include?

Short Description

This PR adds Tooltips for the LDAP SSL/TLS options.

Affected Containers

  • PHP-FPM

@patschi
Copy link
Member

patschi commented Apr 4, 2025

In regards to: TLS is recommended over SSL. I'm not so sure about that. There are pages [1][2][3] which suggest and state seeing SSL (via TCP/636) as deprecated and prefer StartTLS approach.

But StartTLS has the main security-wise disadvantage, that it starts with plain-text communication before upgrading to TLS, and can also be forced to downgrade. Effectively reducing security. So I also found a discussion of OpenLDAP where they are looking to get the dedicated port (SSL) recommended [4][5].

So I'm not sure what is true now. I'd change it to more neutral and leave this up to the customer - the dedicated SSL port seems however more secure, as there is now downgrade possibility which favors security.

Also: I think the "SSL" option does not necessarily refer to the old SSL transport encryption and also includes TLS. It's just some 'legacy' naming.


[1] https://www.openldap.org/faq/data/cache/605.html
[2] https://ldaprecord.com/docs/core/v3/configuration/#ssl--tls:~:text=in%20Active%20Directory.-,TLS%20is%20recommended%20over,SASL,-This%20boolean%20option
[3] https://kb.symas.com/configuration/overview-of-tls-and-ldaps
[4] https://unix.stackexchange.com/questions/607560/why-is-ldap-with-starttls-preferred-over-ldaps
[5] https://lists.openldap.org/hyperkitty/list/[email protected]/thread/IXEZAGCOTL5CTSOFNFDE65LURQET6ZZV/#LZ4N3JHGKZVDXRIXNRAM4SHZ44B5U4BP

@FreddleSpl0it
Copy link
Collaborator Author

@patschi i removed the TLS is recommendations from the tooltips

@FreddleSpl0it FreddleSpl0it merged commit 3ddad9d into staging Apr 7, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants