Skip to content

Commit 3ddad9d

Browse files
Merge pull request #6460 from mailcow/ui/improve-ldap-ssl-labels
[Web] Improve clarity of LDAP SSL/TLS settings
2 parents 428a59d + 2c10c39 commit 3ddad9d

File tree

3 files changed

+30
-10
lines changed

3 files changed

+30
-10
lines changed

data/web/lang/lang.de-de.json

+4-2
Original file line numberDiff line numberDiff line change
@@ -238,7 +238,9 @@
238238
"iam_username_field": "Username Feld",
239239
"iam_binddn": "Bind DN",
240240
"iam_use_ssl": "Benutze SSL",
241-
"iam_use_tls": "Benutze TLS",
241+
"iam_use_ssl_info": "Wenn SSL aktiviert ist und der Port auf 389 gesetzt wurde, wird dieser automatisch auf 636 geändert.",
242+
"iam_use_tls": "Benutze StartTLS",
243+
"iam_use_tls_info": "Wenn TLS aktiviert wird, muss der Standardport deines LDAP-Servers (389) verwendet werden. SSL-Ports können dabei nicht verwendet werden.",
242244
"iam_version": "Version",
243245
"ignore_ssl_error": "Ignoriere SSL Fehler",
244246
"import": "Importieren",
@@ -1333,7 +1335,7 @@
13331335
"tag_in_subfolder": "In Unterordner",
13341336
"tag_in_subject": "In Betreff",
13351337
"text": "Text",
1336-
"tfa_info": "Zwei-Faktor-Authentifizierung hilft dabei, Ihr Konto zu schützen. Wenn Sie sie aktivieren, benötigen Sie möglicherweise App-Passwörter, um sich bei Apps oder Diensten anzumelden, die die Zwei-Faktor-Authentifizierung nicht unterstützen (z.B. Mailclients).",
1338+
"tfa_info": "Zwei-Faktor-Authentifizierung hilft dabei, Ihr Konto zu schützen. Wenn Sie sie aktivieren, benötigen Sie App-Passwörter, um sich bei Apps oder Diensten anzumelden, die die Zwei-Faktor-Authentifizierung nicht unterstützen (z.B. Mailclients).",
13371339
"title": "Title",
13381340
"tls_enforce_in": "TLS eingehend erzwingen",
13391341
"tls_enforce_out": "TLS ausgehend erzwingen",

data/web/lang/lang.en-gb.json

+4-2
Original file line numberDiff line numberDiff line change
@@ -245,7 +245,9 @@
245245
"iam_username_field": "Username Field",
246246
"iam_binddn": "Bind DN",
247247
"iam_use_ssl": "Use SSL",
248-
"iam_use_tls": "Use TLS",
248+
"iam_use_ssl_info": "If enabling SSL, and port is set to 389, it will be automatically overridden to use 636.",
249+
"iam_use_tls": "Use StartTLS",
250+
"iam_use_tls_info": "If enabling TLS, you must use the default port for your LDAP server (389). SSL ports cannot be used.",
249251
"iam_version": "Version",
250252
"ignore_ssl_error": "Ignore SSL Errors",
251253
"import": "Import",
@@ -1355,7 +1357,7 @@
13551357
"tag_in_subfolder": "In subfolder",
13561358
"tag_in_subject": "In subject",
13571359
"text": "Text",
1358-
"tfa_info": "Two-factor authentication helps protect your account. If you enable it, you may need app passwords to log in to apps or services that don't support two-factor authentication (e.g. Mailclients).",
1360+
"tfa_info": "Two-factor authentication helps protect your account. If you enable it, you need app passwords to log in to apps or services that don't support two-factor authentication (e.g. Mailclients).",
13591361
"title": "Title",
13601362
"tls_enforce_in": "Enforce TLS incoming",
13611363
"tls_enforce_out": "Enforce TLS outgoing",

data/web/templates/admin/tab-config-identity-provider.twig

+22-6
Original file line numberDiff line numberDiff line change
@@ -392,11 +392,11 @@
392392
<input type="hidden" name="authsource" value="ldap">
393393
<div class="row mb-2">
394394
<div class="col-md-3 d-flex align-items-center justify-content-md-end">
395-
<i style="font-size: 16px; cursor: pointer;" class="bi bi-patch-question-fill m-2 ms-0" data-bs-toggle="tooltip" data-bs-html="true" data-bs-placement="bottom" title="{{ lang.admin.iam_host_info }}"></i>
395+
<i style="font-size: 16px; cursor: pointer;" class="bi bi-patch-question-fill mx-2 ms-0" data-bs-toggle="tooltip" data-bs-html="true" data-bs-placement="bottom" title="{{ lang.admin.iam_host_info }}"></i>
396396
<label class="control-label" for="iam_ldap_host">{{ lang.admin.iam_host }}:</label>
397397
</div>
398398
<div class="col-12 col-md-9 col-lg-4 d-flex">
399-
<input type="text" class="form-control" id="iam_ldap_host" name="host" value="{{ iam_settings.host }}" required>
399+
<input type="text" class="form-control" id="iam_ldap_host" name="host" value="{{ iam_settings.host }}" required>
400400
</div>
401401
</div>
402402
<div class="row mb-2">
@@ -409,21 +409,37 @@
409409
</div>
410410
<div class="row mb-2">
411411
<div class="col-md-3 d-flex align-items-center justify-content-md-end">
412+
<i style="font-size: 16px; cursor: pointer;" class="bi bi-patch-question-fill mx-2 ms-0" data-bs-toggle="tooltip" data-bs-html="true" data-bs-placement="bottom" title="{{ lang.admin.iam_use_ssl_info }}"></i>
412413
<label class="control-label">{{ lang.admin.iam_use_ssl }}</label>
413414
</div>
414-
<div class="col-12 col-md-9">
415+
<div class="col-12 col-md-9 d-flex align-items-center">
415416
<div class="form-check form-switch">
416-
<input class="form-check-input" type="checkbox" role="switch" name="use_ssl" value="1" {% if iam_settings.use_ssl == 1 %}checked{% endif %}>
417+
<input class="form-check-input"
418+
type="checkbox"
419+
role="switch"
420+
id="use_ssl"
421+
name="use_ssl"
422+
value="1"
423+
onchange="if(this.checked) document.getElementById('use_tls').checked = false"
424+
{% if iam_settings.use_ssl == 1 %}checked{% endif %}>
417425
</div>
418426
</div>
419427
</div>
420428
<div class="row mb-2">
421429
<div class="col-md-3 d-flex align-items-center justify-content-md-end">
430+
<i style="font-size: 16px; cursor: pointer;" class="bi bi-patch-question-fill mx-2 ms-0" data-bs-toggle="tooltip" data-bs-html="true" data-bs-placement="bottom" title="{{ lang.admin.iam_use_tls_info }}"></i>
422431
<label class="control-label">{{ lang.admin.iam_use_tls }}</label>
423432
</div>
424-
<div class="col-12 col-md-9">
433+
<div class="col-12 col-md-9 d-flex align-items-center">
425434
<div class="form-check form-switch">
426-
<input class="form-check-input" type="checkbox" role="switch" name="use_tls" value="1" {% if iam_settings.use_tls == 1 %}checked{% endif %}>
435+
<input class="form-check-input"
436+
type="checkbox"
437+
role="switch"
438+
id="use_tls"
439+
name="use_tls"
440+
value="1"
441+
onchange="if(this.checked) document.getElementById('use_ssl').checked = false"
442+
{% if iam_settings.use_tls == 1 %}checked{% endif %}>
427443
</div>
428444
</div>
429445
</div>

0 commit comments

Comments
 (0)