Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

samples(storage transfer): add samples and test cases for storage transfer services #9

Open
wants to merge 57 commits into
base: main
Choose a base branch
from
Open

samples(storage transfer): add samples and test cases for storage transfer services #9

wants to merge 57 commits into from

Conversation

mahendra-google
Copy link
Owner

@mahendra-google mahendra-google commented Jan 30, 2025 •
edited by amrik-mahal
Loading

Adding samples and tests cases for following storage transfer services:

  • 1. storagetransfer_quickstart
  • 2. storagetransfer_transfer_to_nearline
  • 3. storagetransfer_get_latest_transfer_operation
  • 4. storagetransfer_manifest_request
  • 5. storagetransfer_transfer_from_posix
  • 6. storagetransfer_download_to_posix
  • 7. storagetransfer_transfer_posix_to_posix
  • 8. storagetransfer_create_event_driven_gcs_transfer

mahendra-google and others added 30 commits October 9, 2024 02:00
@mahendra-google
feat(Storage Transfer) : Addition of Sample and Test Case for storage…
ba3c128 
…transfer_transfer_to_nearline.
@mahendra-google
Merge branch 'missing_.net_transfer_service_samples' of https://githu…
c2982ef 
…b.com/mahendra-google/dotnet-docs-samples into missing_.net_transfer_service_samples
@mahendra-google
feat(Storage Transfer) : Addition of Schedule End Date in Sample for …
36706a4 
…storagetransfer_transfer_to_nearline.
@mahendra-google
samples(storage transfer) : Addition of schedule end date in sample f…
afcba29 
…or storagetransfer_transfer_to_nearline.
@mahendra-google
Merge branch 'missing_.net_transfer_service_samples' of https://githu…
5d43c18 
…b.com/mahendra-google/dotnet-docs-samples into missing_.net_transfer_service_samples
@mahendra-google
chore(deps): add dependency xunit.abstractions version 2.0.3 to see o…
3efcf76 
…utput message in sample output and related small changes.
@mahendra-google
code changes in transfer to nearline related to capture message in st…
35e18a3 
…andard output of test log summary.
@mahendra-google
feat(storage transfer) : addition of sample and test case to check la…
0acb7fd 
…test transfer operation.
@mahendra-google
Merge branch 'GoogleCloudPlatform:main' into missing_.net_transfer_se…
e3c0619 
…rvice_samples
@mahendra-google
feat (storage transfer) : addition of samples and test cases for tran…
000b432 
…sfer to nearline and check latest transfer operation (#1)
@mahendra-google
Merge branch 'GoogleCloudPlatform:main' into main
910ad26
@mahendra-google
Merge branch 'GoogleCloudPlatform:main' into main
398b3d5
@mahendra-google
storage transfer from POSIX file system to GCS bucket using manifest …
b5d9b10 
…file
@mahendra-google
minor changes
3c9d243
@mahendra-google
samples(storage transfer): transfer from POSIX file system to GCS buc…
f4b73e0 
…ket using manifest file (#2)
@mahendra-google
Merge branch 'GoogleCloudPlatform:main' into main
1acec24
@mahendra-google
addition of sample and test case for transfer from posix
375f1e0
@mahendra-google
samples(storage transfer): add samples and test cases for transfer fr…
81beca4 
…om posix (#3)
@mahendra-google
Merge branch 'GoogleCloudPlatform:main' into main
ce4a089
@mahendra-google
added sample and test case for download to posix storage transfer ser…
139190a 
…vice.
@mahendra-google
samples(storage transfer): add sample and test case for storage trans…
7357db6 
…fer services. (#4)
@mahendra-google
code changes for creation of temp folder in posix file system
bb66a63
@mahendra-google
couple of test checks added in download to posix
526b445
@mahendra-google
samples(storage transfer): code changes in logic for creation of temp…
8a06504 
… folder in posix file system (#5)
@mahendra-google
added sample and test case for posix to posix storage transfer
edc89e4
@mahendra-google
one test check added in posix to posix storage transfer
7d100d4
@mahendra-google
add sample and test case for event driven transfer and few storage fi…
4b88480 
…xture changes
@mahendra-google
samples(storage transfer): code changes for printing messages to cons…
effd0c2 
…ole , rewording , removing some unnecessary symbols, few test checks removed related to posix file transfer.
@mahendra-google @amanda-tarafa
Update storagetransfer/api/StorageTransfer.Samples/TransferUsingManif…
f5d8252 
…estSample.cs

Co-authored-by: Amanda Tarafa Mas <[email protected]>
@mahendra-google @amanda-tarafa
Update storagetransfer/api/StorageTransfer.Samples.Tests/TransferUsin…
be9c4bb 
…gManifestTest.cs

Co-authored-by: Amanda Tarafa Mas <[email protected]>
amrik-mahal
amrik-mahal requested changes Mar 10, 2025
View reviewed changes
Copy link
Collaborator

@amrik-mahal amrik-mahal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

inline comment for files. overall comments and exception handling related findings

@mahendra-google mahendra-google mentioned this pull request Mar 12, 2025
Open
8 tasks
@mahendra-google
Copy link
Owner Author

inline comment for files. overall comments and exception handling related findings

@amrik-mahal Exception handling is not required in samples unless it is a very specific case that is significantly different from normal try catch code block. Please see the reference conversation in google ( PR )

amrik-mahal
amrik-mahal requested changes Mar 20, 2025
View reviewed changes
Copy link
Collaborator

@amrik-mahal amrik-mahal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. overall feedback to include comment in the tests. single line comment for whole file is also fine.

@mahendra-google
Copy link
Owner Author

@amrik-mahal This PR is ready for re-review

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@harsha-accenture harsha-accenture Awaiting requested review from harsha-accenture

@shubhangi-google shubhangi-google Awaiting requested review from shubhangi-google

@gurusai-voleti gurusai-voleti Awaiting requested review from gurusai-voleti

@thiyaguk09 thiyaguk09 Awaiting requested review from thiyaguk09

@amrik-mahal amrik-mahal Awaiting requested review from amrik-mahal

Assignees

@mahendra-google mahendra-google

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@mahendra-google @thiyaguk09 @amrik-mahal