-
Notifications
You must be signed in to change notification settings - Fork 1.2k
samples(storage transfer): add samples and test cases for storage transfer services #2857
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
samples(storage transfer): add samples and test cases for storage transfer services #2857
Conversation
…transfer_transfer_to_nearline.
…b.com/mahendra-google/dotnet-docs-samples into missing_.net_transfer_service_samples
…storagetransfer_transfer_to_nearline.
…or storagetransfer_transfer_to_nearline.
…b.com/mahendra-google/dotnet-docs-samples into missing_.net_transfer_service_samples
…utput message in sample output and related small changes.
…andard output of test log summary.
…test transfer operation.
…sfer to nearline and check latest transfer operation (#1)
…ket using manifest file (#2)
… folder in posix file system (#5)
…ole , rewording , removing some unnecessary symbols, few test checks removed related to posix file transfer.
@amanda-tarafa Reference from comments I received in Internal PR in samples from .NET reviewer (PR) Just wanted to confirm whether exception handling can be implemented in samples because I don't see its implemented in storage samples also I could see dispose is not failing ? |
We don't usually implement exception handling in samples unless there's a very specific error handling case you need to show. We generally consider that something as follows adds more noise than value:
So, no, don't implement error handling except for a very specific case that is significantly different from the code above. |
This reverts commit f1b05b3.
This PR is ready for re-review. |
@mahendra-google Please fix conflicts so I can run tests, etc. Thanks. |
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks, these look better now. We can address any issue on a one by one basis.
(In general, improvements we request for other samples should be checked for these, thanks)
Adding samples and tests cases for following storage transfer services: