Skip to content

Revert "Add PHP_Codesniffer to require" #55

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 30, 2017
Merged

Revert "Add PHP_Codesniffer to require" #55

merged 1 commit into from
Jun 30, 2017

Conversation

zlik
Copy link
Contributor

@zlik zlik commented Jun 30, 2017

Reverts #54

@zlik
Copy link
Contributor Author

zlik commented Jun 30, 2017

Actually, I double checked and PHP_CodeSnifeer will be installed on the project level even if it was already installed globally:

$ ~/.composer/vendor/bin/phpcs -i
The installed coding standards are MySource, PEAR, PSR1, PSR2, Squiz and Zend
$ composer require magento-ecg/coding-standard 3.1
./composer.json has been created
Loading composer repositories with package information
Updating dependencies (including require-dev)
  - Installing squizlabs/php_codesniffer (3.0.1)
    Loading from cache

  - Installing magento-ecg/coding-standard (3.1)
    Loading from cache

Writing lock file
Generating autoload files

I would like everyone to always install PHPCS globally in their dev enviroments because this is a widely used development tool. Doing so acknowledges the importance of reusability and prevents duplicating components between dev projects.

@zlik zlik merged commit 1e390ed into master Jun 30, 2017
@zlik zlik deleted the revert-54-patch-1 branch June 30, 2017 19:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant