Add PHP_Codesniffer to require

[davidwindell]

No description provided.

[zlik]

I would prefer not to explicitly require PHP_CodeSniffer but rather always install it only once system-wide and use for all projects:

composer global require "squizlabs/php_codesniffer=*"

So I would just update README to indicate this is a desirable method.

[davidwindell]

We use fresh Docker images per project so we wouldn't install it globally.

If you have global required it, won't composer detect this and not install on the project level?

[zlik]

@davidwindell, you're right - PHP_CodeSniffer will not be installed on the project level if installed globally. RP approved.

[zlik]

@davidwindell, I apologize I had to revert the pull request because PHPCS will actually be installed on the project level even when installed globally. You can add a command to install PHPCS globally to your provisioning script. I updated README with the recommended installation method.

[zlik]

@davidwindell,
Note: Alternatively to installing PHP_CodeSniffer globally, you can include dependencies for both magento-ecg/coding-standard and squizlabs/php_codesniffer in your composer.json file. For example:

{
    "require": {
        "magento-ecg/coding-standard": ">=3.0",
        "squizlabs/php_codesniffer": "3.*"
    }
}

[davidwindell]

Yep, that's what we've been doing but the usual practice is to require all dependencies at the vendor level.