[da-DK] Improve grammar #1201
Merged
[da-DK] Improve grammar #1201
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- and streamline wording
dennis
reviewed
Aug 13, 2018
config/locales/da-DK.yml
Outdated
| @@ -21,7 +21,7 @@ da-DK: | |||
| sended: "En email er blevet sendt til '%{email}' med instruktioner for at nulstille dit kodeord." | |||
| user_not_found: "Kan ikke finde en bruger med '%{email}'." | |||
| password_not_required: "Denne bruger kræver ikke et kodeord. Log ind med '%{provider}' konto i stedet." | |||
| missing_passwords: "Du skal fylde alle felter ud som indeholder 'Password' og 'Password confirmation'." | |||
| missing_passwords: "Du skal udfylde alle felter som indeholder 'Password' og 'Password confirmation'." | |||
There was a problem hiding this comment.
Perhaps use "Kodeord" here as well, for consistency. Don't know what "Password confirmation" is translated to in danish.
There was a problem hiding this comment.
This is a harder problem, which a trickier wording could work around, so that we never mentioned the expected labels of those fields.
config/locales/da-DK.yml
Outdated
| confirm_account_link: "Bekræft min konto" | ||
| reset_password_instructions: | ||
| request_reset_link_msg: "Der er nogle der har anmodet om et link til at ændre dit kodeord. Det kan du gøre gennem linket nedenfor." | ||
| password_change_link: "Ændre mit kodeord." | ||
| ignore_mail_msg: "Hvis du ikke anmodede om dette, ignorer venligst denne email." | ||
| no_changes_msg: "Din kodeord vil ikke ændres indtil du går ind på linket ovenfor og laver et nyt et." | ||
| no_changes_msg: "Dit kodeord vil ikke ændres indtil du går ind på linket ovenfor og opretter et nyt et." |
There was a problem hiding this comment.
"Dit kodeord vil ikke ændres indtil du går ind på linket ovenfor og opretter et nyt et."
config/locales/da-DK.yml
Outdated
| confirm_account_link: "Bekræft min konto" | ||
| reset_password_instructions: | ||
| request_reset_link_msg: "Der er nogle der har anmodet om et link til at ændre dit kodeord. Det kan du gøre gennem linket nedenfor." | ||
| password_change_link: "Ændre mit kodeord." | ||
| ignore_mail_msg: "Hvis du ikke anmodede om dette, ignorer venligst denne email." | ||
| no_changes_msg: "Din kodeord vil ikke ændres indtil du går ind på linket ovenfor og laver et nyt et." | ||
| no_changes_msg: "Dit kodeord vil ikke ændres indtil du går ind på linket ovenfor og opretter et nyt et." | ||
| unlock_instructions: | ||
| account_lock_msg: "Din konto er blevet låst fordi der er for mange forkerte log ind-forsøg." |
- Propose wording to avoid mentioning Password field label
jacobat
reviewed
Aug 14, 2018
config/locales/da-DK.yml
Outdated
| unlock_instructions: | ||
| account_lock_msg: "Din konto er blevet låst fordi der er for mange forkerte log ind-forsøg." | ||
| account_lock_msg: "Din konto er blevet låst fordi der er for mange ugyldige log ind-forsøg." |
There was a problem hiding this comment.
Slightly better: ...fordi der har været for mange...
jacobat
reviewed
Aug 14, 2018
config/locales/da-DK.yml
Outdated
| confirm_account_link: "Bekræft min konto" | ||
| reset_password_instructions: | ||
| request_reset_link_msg: "Der er nogle der har anmodet om et link til at ændre dit kodeord. Det kan du gøre gennem linket nedenfor." | ||
| password_change_link: "Ændre mit kodeord." | ||
| ignore_mail_msg: "Hvis du ikke anmodede om dette, ignorer venligst denne email." | ||
| no_changes_msg: "Din kodeord vil ikke ændres indtil du går ind på linket ovenfor og laver et nyt et." | ||
| no_changes_msg: "Dit kodeord vil ikke ændres indtil du går ind på linket ovenfor og opretter et nyt." |
There was a problem hiding this comment.
Dit kodeord vil ikke blive ændret indtil du...
I'm not sure about the context here, it sounds a bit weird to "make a new" password, usually you would say that you change a password.
jacobat
reviewed
Aug 14, 2018
config/locales/da-DK.yml
Outdated
| @@ -21,7 +21,7 @@ da-DK: | |||
| sended: "En email er blevet sendt til '%{email}' med instruktioner for at nulstille dit kodeord." | |||
| user_not_found: "Kan ikke finde en bruger med '%{email}'." | |||
| password_not_required: "Denne bruger kræver ikke et kodeord. Log ind med '%{provider}' konto i stedet." | |||
| missing_passwords: "Du skal fylde alle felter ud som indeholder 'Password' og 'Password confirmation'." | |||
| missing_passwords: "Du skal udfylde alle felter med kodeord og gentagelse af kodeord." | |||
There was a problem hiding this comment.
Perhaps better as Du skal udfylde både kodeord og gentagelse af kodeord? As it stands now it reads like there's multiple password and multiple confirmation fields.
There was a problem hiding this comment.
Usually confirmation is translated to bekræftelse btw.
|
@jacobat Mange tak! Thanks for improving this PR! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR makes more tiny edits to the Danish language file.
In addition: the Devise project wiki's section on Danish has a few competing sets of translation, and none of the translations apart from
en.ymlis distributed with the gem.