Minor refactor to the input handler #15918
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
y5nw
added
Maintenance
10 tasks
y5nw
force-pushed
the
inputhandler-refactor
branch
from
7e487f3 to
6c2393c
Compare
|
Actually we can scratch this since this does not really make things easier. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR makes a minor refactor to the input handler to ease implementation for future PRs.
std::hash<KeyPress>.KeyListis dropped in favor of its STL-based counterpart (i.e.std::unordered_set).No.
It eases the implementation for Allow keybindings with modifiers #14874 and Implement secondary keybindings #15577.
To do
This PR is Ready for Review.
How to test
Manual testing: make sure that keyboard input works.