-
Notifications
You must be signed in to change notification settings - Fork 2.1k
Allow keybindings with modifiers #14874
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Closed
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
BREAKING: LSHIFT, RSHIFT are now _always_ treated as the same key (SHIFT). Same for LCONTROL and RCONTROL.
11 tasks
Closing for now. #15934 has higher priority IMO, and its (potential) followups are more impactful. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Adoption needed
The pull request needs someone to adopt it. Adoption welcomed!
@ Client / Controls / Input
Feature ✨
PRs that add or enhance a feature
Rebase needed
The PR needs to be rebased by its author
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR allows users to create keybindings with modifier keys, such as Control-F10 or Shift-5.
This PR extends the
KeyPress
class to include information on the state of modifier keys.No.
No
This provides a partial workaround for SDL: Some keybinds broken due to missing character lookup #14545 by allowing users to use e.g. Shift-7 instead ofSome people may want to continue using e.g. Shift-7, which will no longer be possible with SDL: Use scancodes for keybindings #14964./
for keybindings.Notes
This PR removes the incompatible feature where Shift+key binds to the "character" rather than the keycode. However, my testing shows that this removed feature did not fully work anyway.(Update: This feature is already dropped by SDL: Use scancodes for keybindings #14964).To do
This PR is a Draft.
KeyPress
KeyList
MyEventReceiver
(src/client/inputhandler.h
)How to test