Skip to content

refactor: pr/branch details & environment views #744

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 8 commits into from
May 30, 2025

Conversation

egekocabas
Copy link
Member

@egekocabas egekocabas commented May 22, 2025

Screenshots

Screen.Recording.2025-05-23.at.01.12.59.mov

Copy link

codacy-production bot commented May 22, 2025

Coverage summary from Codacy

See diff coverage on Codacy

Coverage variation Diff coverage
+0.83% (target: -1.00%)
Coverage variation details
Coverable lines Covered lines Coverage
Common ancestor commit (5078ff6) 7687 998 12.98%
Head commit (488b9af) 7687 (+0) 1062 (+64) 13.82% (+0.83%)

Coverage variation is the difference between the coverage for the head and common ancestor commits of the pull request branch: <coverage of head commit> - <coverage of common ancestor commit>

Diff coverage details
Coverable lines Covered lines Diff coverage
Pull request (#744) 0 0 ∅ (not applicable)

Diff coverage is the percentage of lines that are covered by tests out of the coverable lines that the pull request added or modified: <covered lines added or modified>/<coverable lines added or modified> * 100%

See your quality gate settings    Change summary preferences

@egekocabas egekocabas linked an issue May 22, 2025 that may be closed by this pull request
…etails

# Conflicts:
#	client/src/app/components/environments/environment-accordion/environment-accordion.component.html
#	client/src/app/components/environments/environment-list/environment-list-view.component.html
@egekocabas egekocabas changed the title refactor: pr/branch details view refactor: pr/branch details & environment views May 22, 2025
@egekocabas egekocabas linked an issue May 22, 2025 that may be closed by this pull request
@egekocabas egekocabas marked this pull request as ready for review May 22, 2025 23:16
@egekocabas egekocabas requested a review from a team as a code owner May 22, 2025 23:16
egekocabas and others added 2 commits May 28, 2025 18:30
…etails

# Conflicts:
#	client/src/app/components/environments/environment-list/environment-list-view.component.html
Copy link
Member

@TurkerKoc TurkerKoc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for updating the pr branch detail view. It looks way better now 🙏

@TurkerKoc TurkerKoc merged commit 221646f into staging May 30, 2025
16 checks passed
@TurkerKoc TurkerKoc deleted the feat/refactor-pr-details branch May 30, 2025 00:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Feature]: Allow locking environments in the environments list UI Changes for PR Detail Page
2 participants