Feat: added target configuration + event-factory support #27
Conversation
|
@yaauie please give it an 👁️ I was thinking |
kares
changed the title
There was a problem hiding this comment.
Left a suggestion for improving formatting preexisting content that I hope you will consider. Otherwise, LGTM!
(also this codec was missing proper documentation for the other existing option)
Your work here is much appreciated, @kares. Thank you! ❤️
docs/index.asciidoc
Outdated
| @@ -41,3 +41,44 @@ Notes: | |||
| * the fluent uses a second-precision time for events, so you will never see | |||
| subsecond precision on events processed by this codec. | |||
There was a problem hiding this comment.
I know that this was pre-existing, but we can improve it by using this instead:
NOTE: The fluent uses a second-precision time for events, so you will never see subsecond precision on events processed by this codec.
There was a problem hiding this comment.
Also, it seems like a word is missing. "NOTE: The fluent ________ uses a second-precision time..." Should that be the fluent schema? The fluent codec?
There was a problem hiding this comment.
if it's missing something than it would be the msgpack schema but it's a fluent specific use here ... would this work?
| subsecond precision on events processed by this codec. | |
| NOTE: Fluent uses second-precision for events, so you will not see sub-second precision on events processed by this codec. |
(honestly not even sure if that statement is true anymore)
There was a problem hiding this comment.
Your call. We should move forward to get your other important changes in. Perhaps we open an issue for tracking the validity of the statement?
I've approved, and I trust your judgement on how to proceed. Lemme know if you'd like for me to open an issue.
Sets up usage of LS'
event_factorysupport. Also added an optionalconfig :target.Some minor refactorings along the way.
We avoid
FixnumRuby warnings + include a small bug fix for nano-second precision handling.closes #26