Handle Time.at second argument correctly #26
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@colinsurprenant @jsvd Could you kindly take a look? |
The second argument of Time.at will be handled with usec unit. Signed-off-by: Hiroshi Hatake <[email protected]>
cosmo0920
force-pushed
the
handle-Time.at-second-argument-correctly
branch
from
23fa5af to
5d60b84
Compare
|
@ckoenig This patch fixes your issue? |
Yes, that fixes our issue. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The second argument of Time.at will be handled with usec unit.
Fix for #18 (comment).
Signed-off-by: Hiroshi Hatake [email protected]
Thanks for contributing to Logstash! If you haven't already signed our CLA, here's a handy link: https://www.elastic.co/contributor-agreement/