-
Notifications
You must be signed in to change notification settings - Fork 66
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[feat][wip] : add ipv6 ipam to CCM #369
base: main
Are you sure you want to change the base?
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #369 +/- ##
==========================================
- Coverage 73.48% 73.46% -0.03%
==========================================
Files 15 15
Lines 2682 2668 -14
==========================================
- Hits 1971 1960 -11
+ Misses 544 542 -2
+ Partials 167 166 -1 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
47b9f3b
to
477a5a6
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Copilot reviewed 9 out of 10 changed files in this pull request and generated 1 comment.
Files not reviewed (1)
- go.mod: Language not supported
// failure: more than cidrs is not allowed even with dual stack | ||
if len(clusterCIDRs) > maxAllowedNodeCIDRs { | ||
return fmt.Errorf("len of clusters is:%v > more than max allowed of %d", len(clusterCIDRs), maxAllowedNodeCIDRs) | ||
if clusterCIDRs[0].IP.To4() == nil { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Accessing clusterCIDRs[0] without checking if the slice is non-empty can lead to a runtime panic. Consider adding a guard to ensure that at least one CIDR is provided before performing the check.
Copilot is powered by AI, so mistakes are possible. Review output carefully before use.
General:
Pull Request Guidelines: