add tests for cloud_allocator

Author: rahulait

cloud/linode/nodeipamcontroller.go

@@ -64,6 +64,10 @@ func startNodeIpamController(stopCh <-chan struct{}, cloud cloudprovider.Interfa
 		return fmt.Errorf("too many clusterCIDRs specified for ipv4, max allowed is %d", maxAllowedNodeCIDRsIPv4)
 	}
 
+	if clusterCIDRs[0].IP.To4() == nil {
+		return fmt.Errorf("clusterCIDR %s is not ipv4", clusterCIDRs[0].String())
+	}
+
 	/* TODO: uncomment and fix if we want to support service cidr overlap with nodecidr
 	// service cidr processing
 	if len(strings.TrimSpace(nodeIPAMConfig.ServiceCIDR)) != 0 {

cloud/linode/nodeipamcontroller_test.go

@@ -163,6 +163,18 @@ func Test_startNodeIpamController(t *testing.T) {
 			},
 			wantErr: true,
 		},
+		{
+			name: "ipv6 cidr specified",
+			args: args{
+				stopCh:            make(<-chan struct{}),
+				cloud:             nil,
+				nodeInformer:      nil,
+				kubeclient:        nil,
+				allocateNodeCIDRs: true,
+				clusterCIDR:       "fd00::/80",
+			},
+			wantErr: true,
+		},
 		{
 			name: "more than one cidr specified",
 			args: args{

cloud/nodeipam/ipam/cloud_allocator.go

@@ -183,8 +183,8 @@ func (c *cloudAllocator) Run(ctx context.Context) {
 
 	defer c.queue.ShutDown()
 
-	logger.Info("Starting range CIDR allocator")
-	defer logger.Info("Shutting down range CIDR allocator")
+	logger.Info("Starting linode's cloud CIDR allocator")
+	defer logger.Info("Shutting down linode's cloud CIDR allocator")
 
 	if !cache.WaitForNamedCacheSync("cidrallocator", ctx.Done(), c.nodesSynced) {
 		return