Skip to content

feat: APL-556, Add self-service option for admins to add external helm charts to the catalog #1979

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 9 commits into from
Mar 7, 2025

Conversation

dennisvankekem
Copy link
Contributor

@dennisvankekem dennisvankekem commented Mar 3, 2025

APL-Console:
https://github.com/linode/apl-console/pull/519

APL-Api:
https://github.com/linode/apl-api/pull/642

APL-Core:
#1979

Checklist

  • Architecture Design Records have been added as adr/*.md and appended to list in adr/_index.md, if applicable.
  • The values-schema.yaml file and test/** fixtures have been updated to reflect code changes, if applicable.
  • The OpenApi Schema from redkubes/otomi-api project is compatible with definitions from values-schema.yaml file, if applicable.
  • Helm releases are meeting otomi's baseline security policies, if applicable.
  • Helm chart and helmfile changes are tested against upgrade scenario, if applicable.

Copy link

github-actions bot commented Mar 3, 2025

Coverage report

St.
Category Percentage Covered / Total
🔴 Statements
47.29% (+0.11% 🔼)
900/1903
🔴 Branches
27.87% (+0.49% 🔼)
170/610
🔴 Functions
39.34% (+0.41% 🔼)
96/244
🔴 Lines
46.37% (+0.12% 🔼)
785/1693

Test suite run success

63 tests passing in 8 suites.

Report generated by 🧪jest coverage report action from 4efbd28

@j-zimnowoda j-zimnowoda requested review from j-zimnowoda and merll March 6, 2025 11:04
Copy link
Collaborator

@ferruhcihan ferruhcihan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've tested it with a cluster, it works. LGTM

@ferruhcihan ferruhcihan merged commit fb993e1 into main Mar 7, 2025
8 checks passed
@ferruhcihan ferruhcihan deleted the APL-556 branch March 7, 2025 08:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants