feat: APL-556, Add self-service option for admins to add external helm charts to the catalog (#1979)

Co-authored-by: Sander Rodenhuis <[email protected]>
Co-authored-by: Ferruh Cihan <[email protected]>

Author: 3 people

charts/team-ns/templates/argocd/argocd-applicationset.yaml

@@ -18,8 +18,9 @@ spec:
   template:
     metadata:
       name: 'team-{{ $v.teamId }}-{{ .name }}'
-      {{- if or (eq $a.type "digest") (eq $a.type "semver") }}
       annotations:
+        argocd.argoproj.io/sync-options: SkipDryRunOnMissingResource=true
+      {{- if or (eq $a.type "digest") (eq $a.type "semver") }}
         argocd-image-updater.argoproj.io/team-{{ $v.teamId }}-{{ .name }}.force-update: 'true'
         argocd-image-updater.argoproj.io/team-{{ $v.teamId }}-{{ .name }}.pull-secret: 'pullsecret:argocd/copy-team-{{ $v.teamId }}-harbor-pullsecret'
         argocd-image-updater.argoproj.io/git-branch: main
@@ -52,6 +53,11 @@ spec:
           # The argocd template the values parameter is taken from the git generator path
           values: '{{ "{{values}}" }}'
           releaseName: '{{ .name }}'
+          {{- if and (.sidecarInject) (.createNamespace) }}
+          parameters:
+            - name: sidecar.istio.io/inject
+              value: 'true'
+          {{- end }}
       syncPolicy:
         automated:
           allowEmpty: false
@@ -65,6 +71,10 @@ spec:
         {{- if eq $v.teamId "admin" }} 
         syncOptions:
           - RespectIgnoreDifferences=true
+          - ServerSideApply=true
+          {{- if .createNamespace }}
+          - CreateNamespace=true
+          {{- end }}
       ignoreDifferences:
         - group: admissionregistration.k8s.io
           kind: ValidatingWebhookConfiguration

tests/fixtures/env/teams/workloads.admin.yaml

@@ -5,6 +5,9 @@ teamConfig:
               url: https://myrepo.local/mychart.git
               path: /
               revision: HEAD
+              namespace: kserve
+              createNamespace: true
+              sidecarInject: true
             - name: wa2
               url: https://myregistry.local/mychart
               chart: mychart

values-schema.yaml

@@ -1421,6 +1421,12 @@ definitions:
       namespace:
         description: Workload namespace. Applicable only for team-admin. Default value is 'team-<team_id>'
         $ref: '#/definitions/idName'
+      createNamespace:
+        type: boolean
+        default: false
+      sidecarInject:
+        type: boolean
+        default: false
       imageUpdateStrategy:
         description: Automatically update the image. Only supported wit Helm charts in local Gitea repository and images stored in Harbor.
         title: Auto Image Updater