-
Notifications
You must be signed in to change notification settings - Fork 104
[WIP] Added more informative output - Addresses #42 #47
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
[WIP] Added more informative output - Addresses #42 #47
Conversation
- show the args shiv will be using - Notify the user which output file was written and if an automatic entry point has been applied - color the ouput from pip in blue to distinguish it from whats coming from shiv. Matches Pipenv for familiararity - Fixes linkedin#42
Pull Request Test Coverage Report for Build 309
💛 - Coveralls |
- --ignore-missing-imports looks required for deps with no typedefs.
@sixninetynine - any chance to take a quick look at this ? |
Hey @Imaclean74 Sorry for the delay in getting back to you. To be completely honest I'm not wild about this change, but given what we are talking about here (UX) there is a lot of subjectivity. Here are my main concerns, perhaps we can find a comfortable middle ground: 1.) I'm not fond of the idea of adding 2 additional dependencies for formatting the output. If I think a good path forward here would be to drop all this output into debug-level log messages and add an additional command line flag |
I'll just add that we understand the desire to have a more colorful or verbose output, but ... On the other hand, the users who use shiv as just a command-line utility they directly interact with may want to have more output and colorize it perhaps. The usual way to resolve these two conflicting wishes is to use extra in the Python package specification. That way you can ask to install shiv with an extra to colorize it or make it verbose. For example The extras can be added using |
Hi @sixninetynine - thanks for reviewing. re 1. Yep - I was thinking the same thing - pretty much everything I'm using crayons for can be done with click - it's just a bit more convenient - I can remove. Similarly - a spinner isn't critical - but can be nice for longer running callouts - to pip for example. I'm fine to remove it.
Lastly - do we want to keep at least the output file name on the final line ? |
This my first attempt and may well err on the side of being too verbose. Appreciate any feedback on how to make it better.
Here's some example output from a very simple shiv command.