Skip to content

Make shivs output a little more informative #42

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
Imaclean74 opened this issue Jun 25, 2018 · 4 comments
Open

Make shivs output a little more informative #42

Imaclean74 opened this issue Jun 25, 2018 · 4 comments

Comments

@Imaclean74
Copy link

Imaclean74 commented Jun 25, 2018 •
edited
Loading

Just a couple of things that could make the usage experience a little better ;

  • Confirmation that an output file was written. ie generated pyz to <output_file> or similar
  • Flagging of success vs some error condition. I was getting an error for a while - but wasn't entirely sure if it was just a warning - since the last output line is just "done".

If there is agreement that this would be useful I'm happy to put a quick PR together.
@lorencarvalho
Copy link
Contributor

Confirmation that an output file was written. ie generated pyz to <output_file> or similar

This would be a welcome addition. Perhaps instead of just "done!" the confirmation could go here?

Flagging of success vs some error condition. I was getting an error for a while - but wasn't entirely sure if it was just a warning - since the last output line is just "done".

Proper exit codes should be being set (via sys.exit)... Curious what the specific error you ran into was, because "done" should indicate that the pyz was built successfully.

@Imaclean74
Copy link
Author

aah - right you are - it didn't output done. Apologies - perhaps I was expecting a more forceful "Failed" error message.

Imaclean74 added a commit to Imaclean74/shiv that referenced this issue Jul 29, 2018
@Imaclean74
Added more informative output
b897d4a 
- show the args shiv will be using
- Notify the user which output file was written and if an automatic entry point has been applied
- color the ouput from pip in blue to distinguish it from whats coming from shiv. Matches Pipenv for familiararity
- Fixes linkedin#42
@Imaclean74
Copy link
Author

finally got around to making the merge request.

@Imaclean74
Copy link
Author

@sixninetynine - I wonder if you could take a look at #47 when you get a chance ?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@lorencarvalho @Imaclean74