-
Notifications
You must be signed in to change notification settings - Fork 569
Rename Stepper builder methods #697
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Looks good! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks functionally equivalent.
To bikeshed: how do we feel about |
|
You can just change it to Not related to your work per se, but I was looking at this Looking at the PR (#308) it seems that initially the code was maybe more functional. if (*data - old_data).abs() > EPSILON {
// callback
(self.value_changed)(ctx, data, env);
} else if self.wrap { However in a commit titled Adress stepper review feedback that was removed and changed to the current non-working code. Also that change doesn't seem to be based on any actual reviewer feedback, so I guess some sort of mistake. Feel free to fix the wraparound code here, or if you'd rather not that's fine too and we'll just merge the method renames only. |
For now I've just renamed The functionality in itself is indeed completely broken, I think I will deal with that in a separate PR after I'm done with #632 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks, this looks good! I'm going to make a few little doc fixes but happy to merge.
This fuses
Stepper::min
andStepper::max
toStepper::with_range
and renamesStepper::step
as well asStepper::wrap
toStepper::with_step
andStepper::with_wrap
respectively.Closes #684