-
Notifications
You must be signed in to change notification settings - Fork 569
Stepper widget #308
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Stepper widget #308
Conversation
For this to work we need some sort of 'validating textbox' that validates its inputs, and can then have it's |
Or rather: that's the mechanism I think this should be built on. We will need data-validation for text entry at some point anyway, so it makes sense to reuse that for this widget. |
Currently exploring such a mechanism in #346. |
@scholtzan sorry to let this sit around for so long, it does look like a solid patch. Maybe it's worth seeing if the basic input validation stuff in #346 helps you at all? |
Thanks! No worries, I've been quite busy the past couple of weeks anyway. Probably will pick it up again after Christmas. |
Alright, I updated the stepper widget example and got it work with textboxes thanks to |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Okay cool, sorry for dragging my feet on this! I have a few little observations, but nothing major; we should be able to get this merged shortly.
Ready for another look |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
okay a few more little nits but basically good to go!
Thanks for the comments. Should be ready for another look. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, one tiny little thing but then this should be good to go. :)
I did some further experimenting and implemented a stepper widget:

I tried to hook it up to a textbox but for it to work textbox would need some kind of
on_change
callback to update the stepper value.