Skip to content

Add joint from world to the floating link #263

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 9 commits into from
Mar 26, 2025

Conversation

Khouloud-Hamrouni
Copy link
Contributor

I added what was recommended as a solution in #230 to the different robots.

@mhubii
Copy link
Member

mhubii commented Mar 25, 2025

thanks for fixing this @Khouloud-Hamrouni ! Will get this merged tomorrow

@mhubii mhubii self-requested a review March 25, 2025 23:30
Copy link
Member

@mhubii mhubii left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Backporting these to humble may require updates to parsing robot description to control node, e.g.

use_sim_time=False, robot_description=robot_description

@mhubii mhubii merged commit 1bf5e68 into lbr-stack:rolling Mar 26, 2025
1 of 7 checks passed
@mhubii
Copy link
Member

mhubii commented Mar 26, 2025

/backport

Copy link

Backport failed for humble, because it was unable to cherry-pick the commit(s).

Please cherry-pick the changes locally and resolve any conflicts.

git fetch origin humble
git worktree add -d .worktree/backport-263-to-humble origin/humble
cd .worktree/backport-263-to-humble
git switch --create backport-263-to-humble
git cherry-pick -x 820ffb4bd8a00fc54bc1782a42f4733ea801c152 5ddb8492a092130d5faf114c94de390704d18cf2 719a24448c7a4ec26a6f19522d05fa74e27df4a3 0665e23eba31d16068fe1bcb95753fb4c8c6b840 e7e58c4972f9d579a2d40213ce06682e26cc6402 a404c9a4b552df5f5225114bade4e65888a07210 c5cf92cc108636833e49ab93efdcbc04f7e72733

mhubii added a commit that referenced this pull request Mar 26, 2025
mhubii added a commit that referenced this pull request Mar 26, 2025
mhubii added a commit that referenced this pull request Mar 26, 2025
(cherry picked from commit 8e048ce)
@mhubii mhubii mentioned this pull request Mar 26, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants