Skip to content

Cartesian Velocity - update #192

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed

Conversation

OmidRezayof
Copy link
Contributor

Dear @mhubii. I tried to merge the latest updates from the master/humble branch and create a new PR.

Of note, the move_2_cart is now a service, and move_to_cart_client will activate the service.

asbr.py is a module written by one of my colleagues in lab and is basically a library for linear algebra/robotic stuff. I asked for his permission to contribute the code but it is not available through pip.

long_lines.py is just a personal code for me and my project. I didn't know how to exclude that from the PR so feel free to reject it.

@mhubii
Copy link
Member

mhubii commented Jun 20, 2024

no worries, lets work through this, thank you for the PR

@mhubii
Copy link
Member

mhubii commented Jul 26, 2024

no worries, so the problem with this PR are changes that are unrelated to the PR, hope this makes sense

@OmidRezayof
Copy link
Contributor Author

Dear @mhubii, I'm sorry I was unaware that this PR is still open.
I have somehow finalized and cleaned up the motion planning in the cartesian space and everything is working and looking good. I think this can be useful to the community. I'm planning to further clean up, add some comments and create a branch with unnecessary files removed and then re-open a PR.
If there has been new commits to the repo that eliminates the need for a cartesian space motion planning and control, please lmk so I wouldn't open a new PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants