Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: document extractor can't parse excel #14695

Merged
merged 1 commit into from
Mar 3, 2025
Merged

fix: document extractor can't parse excel #14695

merged 1 commit into from
Mar 3, 2025

Conversation

hjlarry
Copy link
Contributor

@hjlarry hjlarry commented Mar 3, 2025 •
edited
Loading

Summary

Tip

Close issue syntax: Fixes #<issue number> or Resolves #<issue number>, see documentation for more details.

fix #14557
fix #14693

debug panel:
CleanShot 2025-03-03 at 09 27 55

The tabulate package was installed by vanna in version 0.15.3, but vanna is migrate to tools.

Screenshots

Before After
... ...

Checklist

Important

Please review the checklist below before submitting your pull request.

  • This change requires a documentation update, included: Dify Document
  • I understand that this PR may be closed in case there was no previous discussion or issues. (This doesn't apply to typos!)
  • I've added a test for each change that was introduced, and I tried as much as possible to make a single atomic change.
  • I've updated the documentation accordingly.
  • I ran dev/reformat(backend) and cd web && npx lint-staged(frontend) to appease the lint gods

@dosubot dosubot bot added size:XS This PR changes 0-9 lines, ignoring generated files. dependencies Pull requests that update a dependency file 🐞 bug Something isn't working labels Mar 3, 2025
@dosubot dosubot bot added the lgtm This PR has been approved by a maintainer label Mar 3, 2025
@crazywoola crazywoola merged commit 8d4136d into langgenius:main Mar 3, 2025
8 checks passed
chinnsenn pushed a commit to chinnsenn/dify that referenced this pull request Mar 3, 2025
@hjlarry
fix: document extractor can't parse excel (langgenius#14695)
eb6e66e
@crazywoola crazywoola mentioned this pull request Mar 4, 2025
Closed
5 tasks
This was referenced Mar 10, 2025
Closed
Closed
jackzhuo pushed a commit to jackzhuo/dify that referenced this pull request Mar 14, 2025
@hjlarry @jackzhuo
fix: document extractor can't parse excel (langgenius#14695)
b0c8802
parambharat pushed a commit to parambharat/dify that referenced this pull request Mar 31, 2025
@hjlarry @parambharat
fix: document extractor can't parse excel (langgenius#14695)
39092b9
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@crazywoola crazywoola crazywoola approved these changes

Assignees
No one assigned
Labels
🐞 bug Something isn't working dependencies Pull requests that update a dependency file lgtm This PR has been approved by a maintainer size:XS This PR changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

File upload failed. Excel cannot parse data properly. Doc Extractor, xls files get an empty result
2 participants
@hjlarry @crazywoola