Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove Falco from website #22313

Merged
merged 1 commit into from
Jul 24, 2020
Merged

Remove Falco from website #22313

merged 1 commit into from
Jul 24, 2020

Conversation

tengqm
Copy link
Contributor

@tengqm tengqm commented Jul 4, 2020

This page is dual hosted 3rd party content.

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Jul 4, 2020
@k8s-ci-robot k8s-ci-robot requested review from soltysh and sttts July 4, 2020 02:36
@k8s-ci-robot k8s-ci-robot added language/en Issues or PRs related to English language sig/docs Categorizes an issue or PR as relevant to SIG Docs. labels Jul 4, 2020
@tengqm tengqm mentioned this pull request Jul 4, 2020
Closed
@netlify
Copy link

netlify bot commented Jul 4, 2020 •
edited
Loading

Deploy preview for kubernetes-io-master-staging ready!

Built with commit 280afd8

https://deploy-preview-22313--kubernetes-io-master-staging.netlify.app

@sftim
Copy link
Contributor

sftim commented Jul 11, 2020

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jul 11, 2020
@celestehorgan
Copy link
Contributor

/hold

per https://kubernetes.io/blog/2020/05/third-party-dual-sourced-content/

@k8s-ci-robot k8s-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jul 13, 2020
@k8s-ci-robot k8s-ci-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Jul 20, 2020
@sftim
Copy link
Contributor

sftim commented Jul 22, 2020

@tengqm happy to rebase this? I think we could unhold it given the v1.19 docs deadline has passed.

@tengqm
Remove Falco from website
280afd8 
This content is dual hosted 3rd party content.
@k8s-ci-robot k8s-ci-robot removed lgtm "Looks good to me", indicates that a PR is ready to be merged. needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. labels Jul 22, 2020
@sftim
Copy link
Contributor

sftim commented Jul 22, 2020

/lgtm
/hold cancel

@k8s-ci-robot k8s-ci-robot added lgtm "Looks good to me", indicates that a PR is ready to be merged. and removed do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. labels Jul 22, 2020
@celestehorgan
Copy link
Contributor

/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: celestehorgan

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jul 24, 2020
@k8s-ci-robot k8s-ci-robot merged commit e21e35d into kubernetes:master Jul 24, 2020
@tengqm tengqm deleted the remove-falco branch July 25, 2020 05:18
@sftim sftim mentioned this pull request Oct 3, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@soltysh soltysh Awaiting requested review from soltysh

@sttts sttts Awaiting requested review from sttts

Assignees

@sftim sftim

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. language/en Issues or PRs related to English language lgtm "Looks good to me", indicates that a PR is ready to be merged. sig/docs Categorizes an issue or PR as relevant to SIG Docs. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@tengqm @sftim @celestehorgan @k8s-ci-robot