Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update zh trans falco.md #22290

Closed
wants to merge 1 commit into from
Closed

Conversation

jiazxjason
Copy link
Contributor

Update zh trans falco.md

Update zh trans falco.md
@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Jul 3, 2020
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
To complete the pull request process, please assign haibinxie
You can assign the PR to them by writing /assign @haibinxie in a comment when ready.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot requested review from soltysh and sttts July 3, 2020 07:11
@k8s-ci-robot k8s-ci-robot added language/zh Issues or PRs related to Chinese language sig/docs Categorizes an issue or PR as relevant to SIG Docs. labels Jul 3, 2020
@netlify
Copy link

netlify bot commented Jul 3, 2020

Deploy preview for kubernetes-io-master-staging ready!

Built with commit a1d53bd

https://deploy-preview-22290--kubernetes-io-master-staging.netlify.app

@@ -4,7 +4,7 @@ reviewers:
- sttts
- ericchiang
content_type: concept
title: 使用 Falco 审计
title: 使用 Falco 审核
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

pls change this back. We always use 审计 for auditing

- [Kubernetes DaemonSet][falco_installation]
- [Falco Helm Chart][falco_helm_chart]

安装Falco后,请确保将其配置成公开Audit Webhook。为此,请使用以下配置:
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

注意中英文之间留白


安装Falco后,请确保将其配置成公开Audit Webhook。为此,请使用以下配置:

```
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

“```yaml"


#### 配置 Kubernetes 审核

1. 为 [kube-apiserver](https://github.com/kubernetes/website/blob/release-1.16/docs/admin/kube-apiserver) webhook 审核后台创建一个 [kubeconfig 配置文件](https://github.com/kubernetes/website/blob/release-1.16/docs/concepts/configuration/organize-cluster-access-kubeconfig)。
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

这里的链接都很奇怪,都指向非常老的版本。
Falco 因为是第三方软件,Website 迟早会将其内容删除。
因此,翻译这些内容的意义不大。

@tengqm
Copy link
Contributor

tengqm commented Jul 4, 2020

/hold
I'm not sure we want to keep this.
Will propose a removal of the related content and seek comments from the community.

@k8s-ci-robot k8s-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jul 4, 2020
@tengqm
Copy link
Contributor

tengqm commented Jul 4, 2020

See: #22313

@chenrui333
Copy link
Member

Since we have removed the English content, we should actively close this PR. Thanks @jiazxjason and sorry about not merging this.

@chenrui333
Copy link
Member

/close

@k8s-ci-robot
Copy link
Contributor

@chenrui333: Closed this PR.

In response to this:

/close

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@chenrui333
Copy link
Member

The better idea for future translation might be raising an issue first and tag tengqm for review before the actual translation work. :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. language/zh Issues or PRs related to Chinese language sig/docs Categorizes an issue or PR as relevant to SIG Docs. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants