Skip to content

Fixing search results #863

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Oct 8, 2024
Merged

Fixing search results #863

merged 3 commits into from
Oct 8, 2024
+12 −2

Conversation

wallentx
Copy link
Contributor

Fixes #862

I'm not really sure what might could be added to the tests to account for this.

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Sep 30, 2024
@k8s-ci-robot
Copy link
Contributor

Welcome @wallentx!

It looks like this is your first PR to kubernetes-sigs/krew 🎉. Please refer to our pull request process documentation to help your PR have a smooth ride to approval.

You will be prompted by a bot to use commands during the review process. Do not be afraid to follow the prompts! It is okay to experiment. Here is the bot commands documentation.

You can also check if kubernetes-sigs/krew has its own contribution guidelines.

You may want to refer to our testing guide if you run into trouble with your tests not passing.

If you are having difficulty getting your pull request seen, please follow the recommended escalation practices. Also, for tips and tricks in the contribution process you may want to read the Kubernetes contributor cheat sheet. We want to make sure your contribution gets all the attention it needs!

Thank you, and welcome to Kubernetes. 😃

@k8s-ci-robot k8s-ci-robot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Sep 30, 2024
@chriskim06
Copy link
Member

we should probably add a test case here https://github.com/kubernetes-sigs/krew/blob/master/cmd/krew/cmd/search_test.go#L31-L62 with an empty keyword expecting the full set of names. this bug has probably been in krew for some time

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ahmetb, wallentx

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Sep 30, 2024
@k8s-ci-robot k8s-ci-robot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. and removed size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Oct 1, 2024
@wallentx
Copy link
Contributor Author

wallentx commented Oct 1, 2024

we should probably add a test case here https://github.com/kubernetes-sigs/krew/blob/master/cmd/krew/cmd/search_test.go#L31-L62 with an empty keyword expecting the full set of names. this bug has probably been in krew for some time

I've made the requested changes to the search_test 👍

@chriskim06
Copy link
Member

actually looking into it a bit more, we have this integration test https://github.com/kubernetes-sigs/krew/blob/master/integration_test/search_test.go#L24-L34 but it didnt catch this because it just checks that there are at least 10 lines in the output. wonder if we should update this to an exact number (1 + number of plugins in the cloned index; the 1 being the header line in the search output).

@wallentx
Copy link
Contributor Author

wallentx commented Oct 7, 2024

@chriskim06 I've got Allow edits and access to secrets by maintainers checked, so feel free to do whatever you deem is most appropriate.

@chriskim06
Copy link
Member

ill update the integration test in a follow up pr later today. thanks for catching this and fixing!

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Oct 8, 2024
@k8s-ci-robot k8s-ci-robot merged commit 48b3ea1 into kubernetes-sigs:master Oct 8, 2024
6 of 7 checks passed
@github-actions github-actions bot mentioned this pull request Mar 23, 2025
Open
tmeijn pushed a commit to tmeijn/dotfiles that referenced this pull request Mar 25, 2025
build(deps): update kubernetes-sigs/krew to v0.4.5
91eb1ad 
This MR contains the following updates:

| Package | Update | Change |
|---|---|---|
| [kubernetes-sigs/krew](https://github.com/kubernetes-sigs/krew) | patch | `v0.4.4` -> `v0.4.5` |

MR created with the help of [el-capitano/tools/renovate-bot](https://gitlab.com/el-capitano/tools/renovate-bot).

**Proposed changes to behavior should be submitted there as MRs.**

---

### Release Notes

<details>
<summary>kubernetes-sigs/krew (kubernetes-sigs/krew)</summary>

### [`v0.4.5`](https://github.com/kubernetes-sigs/krew/releases/tag/v0.4.5)

[Compare Source](kubernetes-sigs/krew@v0.4.4...v0.4.5)

## Installation

To install this release, refer to the instructions at https://github.com/kubernetes-sigs/krew/blob/v0.4.5/README.md.

## Release Assets

Artifacts for this release can be downloaded from the following links.
It is recommended to follow [installation instructions](https://github.com/kubernetes-sigs/krew/blob/v0.4.5/README.md)
and not using these artifacts directly.

-   https://github.com/kubernetes-sigs/krew/releases/download/v0.4.5/krew-darwin_amd64.tar.gz
-   https://github.com/kubernetes-sigs/krew/releases/download/v0.4.5/krew-darwin_amd64.tar.gz.sha256
-   https://github.com/kubernetes-sigs/krew/releases/download/v0.4.5/krew-darwin_arm64.tar.gz
-   https://github.com/kubernetes-sigs/krew/releases/download/v0.4.5/krew-darwin_arm64.tar.gz.sha256
-   https://github.com/kubernetes-sigs/krew/releases/download/v0.4.5/krew-linux_amd64.tar.gz
-   https://github.com/kubernetes-sigs/krew/releases/download/v0.4.5/krew-linux_amd64.tar.gz.sha256
-   https://github.com/kubernetes-sigs/krew/releases/download/v0.4.5/krew-linux_arm.tar.gz
-   https://github.com/kubernetes-sigs/krew/releases/download/v0.4.5/krew-linux_arm.tar.gz.sha256
-   https://github.com/kubernetes-sigs/krew/releases/download/v0.4.5/krew-linux_arm64.tar.gz
-   https://github.com/kubernetes-sigs/krew/releases/download/v0.4.5/krew-linux_arm64.tar.gz.sha256
-   https://github.com/kubernetes-sigs/krew/releases/download/v0.4.5/krew-linux_ppc64le.tar.gz
-   https://github.com/kubernetes-sigs/krew/releases/download/v0.4.5/krew-linux_ppc64le.tar.gz.sha256
-   https://github.com/kubernetes-sigs/krew/releases/download/v0.4.5/krew-windows_amd64.tar.gz
-   https://github.com/kubernetes-sigs/krew/releases/download/v0.4.5/krew-windows_amd64.tar.gz.sha256
-   https://github.com/kubernetes-sigs/krew/releases/download/v0.4.5/krew.exe
-   https://github.com/kubernetes-sigs/krew/releases/download/v0.4.5/krew.exe.sha256
-   https://github.com/kubernetes-sigs/krew/releases/download/v0.4.5/krew.yaml

Thanks to our contributors for helping out with v0.4.5:

-   Chris Kim
-   William Allen
-   Wenhao Ji
-   Marvin Beckers
-   Janki Chhatbar
-   Ahmet Alp Balkan

(krew v0.4.5 was tagged on Tue Mar 18 16:41:42 UTC 2025.)

<details>
<summary>Merged pull requests</summary>

Collecting pull request that were merged since the last release: v0.4.4 (2023-07-13 21:53:48 +0000 UTC)

-   docs: updated the link of the plugin stats dashboard [#&#8203;872](kubernetes-sigs/krew#872)
-   use an exact number for search integration test [#&#8203;864](kubernetes-sigs/krew#864)
-   Fixing search results [#&#8203;863](kubernetes-sigs/krew#863)
-   fix: chmod 0755 store/PLUGIN/VER dir [#&#8203;841](kubernetes-sigs/krew#841)
-   Update to Go 1.22 and latest Go dependencies [#&#8203;854](kubernetes-sigs/krew#854)
-   add aliases to a few commands [#&#8203;839](kubernetes-sigs/krew#839)
-   Add missing 'kubectl\` prefix to krew command [#&#8203;842](kubernetes-sigs/krew#842)
-   fix contributors list in release notes [#&#8203;830](kubernetes-sigs/krew#830)

</details>

</details>

---

### Configuration

📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined).

🚦 **Automerge**: Enabled.

♻ **Rebasing**: Whenever MR is behind base branch, or you tick the rebase/retry checkbox.

🔕 **Ignore**: Close this MR and you won't be reminded about this update again.

---

 - [ ] <!-- rebase-check -->If you want to rebase/retry this MR, check this box

---

This MR has been generated by [Renovate Bot](https://github.com/renovatebot/renovate).
<!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzOS4yMTIuMiIsInVwZGF0ZWRJblZlciI6IjM5LjIxMi4yIiwidGFyZ2V0QnJhbmNoIjoibWFpbiIsImxhYmVscyI6WyJSZW5vdmF0ZSBCb3QiXX0=-->
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ahmetb ahmetb ahmetb approved these changes

@chriskim06 chriskim06 Awaiting requested review from chriskim06

@soltysh soltysh Awaiting requested review from soltysh

Assignees

@chriskim06 chriskim06

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Bad output on MacOS
4 participants
@wallentx @k8s-ci-robot @chriskim06 @ahmetb