Skip to content

fix: chmod 0755 store/PLUGIN/VER dir #841

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Nov 10, 2023
Merged

fix: chmod 0755 store/PLUGIN/VER dir #841

merged 1 commit into from
Nov 10, 2023
+6 −1

Conversation

ahmetb
Copy link
Member

@ahmetb ahmetb commented Sep 13, 2023 •
edited
Loading

Because we're doing mktemp (which gives 0700) and then moving it to $KREW_ROOT/store/PLUGIN/VERSION, we need to make sure that the directory is 0755 like the other dirs in store.

See #840.

@ahmetb ahmetb requested a review from chriskim06 September 13, 2023 17:33
@k8s-ci-robot k8s-ci-robot added do-not-merge/invalid-commit-message Indicates that a PR should not merge because it has an invalid commit message. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Sep 13, 2023
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ahmetb

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added approved Indicates a PR has been approved by an approver from all required OWNERS files. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Sep 13, 2023
@ahmetb ahmetb force-pushed the ahmet/fix-store-chmod branch 2 times, most recently from fafb1e8 to 04a4bf0 Compare September 13, 2023 17:34
@ngoeddel-openi
Copy link

Excuse my impatience. When approximately can I expect the fix and in which version will it happen?

@ngoeddel-openi
Copy link

Can please someone add this lgtm label and remove do-not-merge/invalid-commit-message or what's the issue here?
Thank you!

@ahmetb
fix: chmod 0755 store/PLUGIN/VER dir
2ebe63b 
Because we're doing `mktemp` (which gives 0700) and then moving it to
`$KREW_ROOT/store/PLUGIN/VERSION`, we need to make sure that the
directory is 0755 like the other dirs in `store`.
@ahmetb ahmetb force-pushed the ahmet/fix-store-chmod branch from 04a4bf0 to 2ebe63b Compare November 10, 2023 17:49
@k8s-ci-robot k8s-ci-robot removed the do-not-merge/invalid-commit-message Indicates that a PR should not merge because it has an invalid commit message. label Nov 10, 2023
@chriskim06
Copy link
Member

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Nov 10, 2023
@k8s-ci-robot k8s-ci-robot merged commit 2e6cfb3 into kubernetes-sigs:master Nov 10, 2023
@ngoeddel-openi
Copy link

@ahmetb May I ask when you will bring out a new release?

@chriskim06 chriskim06 mentioned this pull request Mar 18, 2025
Closed
@github-actions github-actions bot mentioned this pull request Mar 23, 2025
Open
tmeijn pushed a commit to tmeijn/dotfiles that referenced this pull request Mar 25, 2025
build(deps): update kubernetes-sigs/krew to v0.4.5
91eb1ad 
This MR contains the following updates:

| Package | Update | Change |
|---|---|---|
| [kubernetes-sigs/krew](https://github.com/kubernetes-sigs/krew) | patch | `v0.4.4` -> `v0.4.5` |

MR created with the help of [el-capitano/tools/renovate-bot](https://gitlab.com/el-capitano/tools/renovate-bot).

**Proposed changes to behavior should be submitted there as MRs.**

---

### Release Notes

<details>
<summary>kubernetes-sigs/krew (kubernetes-sigs/krew)</summary>

### [`v0.4.5`](https://github.com/kubernetes-sigs/krew/releases/tag/v0.4.5)

[Compare Source](kubernetes-sigs/krew@v0.4.4...v0.4.5)

## Installation

To install this release, refer to the instructions at https://github.com/kubernetes-sigs/krew/blob/v0.4.5/README.md.

## Release Assets

Artifacts for this release can be downloaded from the following links.
It is recommended to follow [installation instructions](https://github.com/kubernetes-sigs/krew/blob/v0.4.5/README.md)
and not using these artifacts directly.

-   https://github.com/kubernetes-sigs/krew/releases/download/v0.4.5/krew-darwin_amd64.tar.gz
-   https://github.com/kubernetes-sigs/krew/releases/download/v0.4.5/krew-darwin_amd64.tar.gz.sha256
-   https://github.com/kubernetes-sigs/krew/releases/download/v0.4.5/krew-darwin_arm64.tar.gz
-   https://github.com/kubernetes-sigs/krew/releases/download/v0.4.5/krew-darwin_arm64.tar.gz.sha256
-   https://github.com/kubernetes-sigs/krew/releases/download/v0.4.5/krew-linux_amd64.tar.gz
-   https://github.com/kubernetes-sigs/krew/releases/download/v0.4.5/krew-linux_amd64.tar.gz.sha256
-   https://github.com/kubernetes-sigs/krew/releases/download/v0.4.5/krew-linux_arm.tar.gz
-   https://github.com/kubernetes-sigs/krew/releases/download/v0.4.5/krew-linux_arm.tar.gz.sha256
-   https://github.com/kubernetes-sigs/krew/releases/download/v0.4.5/krew-linux_arm64.tar.gz
-   https://github.com/kubernetes-sigs/krew/releases/download/v0.4.5/krew-linux_arm64.tar.gz.sha256
-   https://github.com/kubernetes-sigs/krew/releases/download/v0.4.5/krew-linux_ppc64le.tar.gz
-   https://github.com/kubernetes-sigs/krew/releases/download/v0.4.5/krew-linux_ppc64le.tar.gz.sha256
-   https://github.com/kubernetes-sigs/krew/releases/download/v0.4.5/krew-windows_amd64.tar.gz
-   https://github.com/kubernetes-sigs/krew/releases/download/v0.4.5/krew-windows_amd64.tar.gz.sha256
-   https://github.com/kubernetes-sigs/krew/releases/download/v0.4.5/krew.exe
-   https://github.com/kubernetes-sigs/krew/releases/download/v0.4.5/krew.exe.sha256
-   https://github.com/kubernetes-sigs/krew/releases/download/v0.4.5/krew.yaml

Thanks to our contributors for helping out with v0.4.5:

-   Chris Kim
-   William Allen
-   Wenhao Ji
-   Marvin Beckers
-   Janki Chhatbar
-   Ahmet Alp Balkan

(krew v0.4.5 was tagged on Tue Mar 18 16:41:42 UTC 2025.)

<details>
<summary>Merged pull requests</summary>

Collecting pull request that were merged since the last release: v0.4.4 (2023-07-13 21:53:48 +0000 UTC)

-   docs: updated the link of the plugin stats dashboard [#&#8203;872](kubernetes-sigs/krew#872)
-   use an exact number for search integration test [#&#8203;864](kubernetes-sigs/krew#864)
-   Fixing search results [#&#8203;863](kubernetes-sigs/krew#863)
-   fix: chmod 0755 store/PLUGIN/VER dir [#&#8203;841](kubernetes-sigs/krew#841)
-   Update to Go 1.22 and latest Go dependencies [#&#8203;854](kubernetes-sigs/krew#854)
-   add aliases to a few commands [#&#8203;839](kubernetes-sigs/krew#839)
-   Add missing 'kubectl\` prefix to krew command [#&#8203;842](kubernetes-sigs/krew#842)
-   fix contributors list in release notes [#&#8203;830](kubernetes-sigs/krew#830)

</details>

</details>

---

### Configuration

📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined).

🚦 **Automerge**: Enabled.

♻ **Rebasing**: Whenever MR is behind base branch, or you tick the rebase/retry checkbox.

🔕 **Ignore**: Close this MR and you won't be reminded about this update again.

---

 - [ ] <!-- rebase-check -->If you want to rebase/retry this MR, check this box

---

This MR has been generated by [Renovate Bot](https://github.com/renovatebot/renovate).
<!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzOS4yMTIuMiIsInVwZGF0ZWRJblZlciI6IjM5LjIxMi4yIiwidGFyZ2V0QnJhbmNoIjoibWFpbiIsImxhYmVscyI6WyJSZW5vdmF0ZSBCb3QiXX0=-->
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chriskim06 chriskim06 Awaiting requested review from chriskim06

@corneliusweig corneliusweig Awaiting requested review from corneliusweig

@soltysh soltysh Awaiting requested review from soltysh

Assignees

@chriskim06 chriskim06

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@ahmetb @k8s-ci-robot @ngoeddel-openi @chriskim06