Skip to content

frontend: Sidebar: Fix conditional expansion description text #3277

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

frontend: Sidebar: Fix conditional expansion description text #3277

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
87a37d3
frontend: Sidebar: Fix conditional expansion description text
Pratik-050 May 18, 2025
b526cae
frontend: Sidebar: Snapshot tests updated
Pratik-050 May 18, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion frontend/src/components/Sidebar/Sidebar.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -120,7 +120,7 @@ function SidebarToggleButton() {
dispatch(setWhetherSidebarOpen(!isOpen));
}}
icon={isOpen ? 'mdi:chevron-left-box-outline' : 'mdi:chevron-right-box-outline'}
description={t('translation|Collapse Sidebar')}
description={isOpen ? t('translation|Shrink sidebar') : t('translation|Expand sidebar')}
/>
</Box>
);
Expand Down
2 changes: 1 addition & 1 deletion frontend/src/components/Sidebar/__snapshots__/Sidebar.HomeSidebarClosed.stories.storyshot
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -187,7 +187,7 @@
class="MuiBox-root css-xi606m"
>
<button
aria-label="Collapse Sidebar"
aria-label="Expand sidebar"
class="MuiButtonBase-root MuiIconButton-root MuiIconButton-sizeSmall css-lr7sro-MuiButtonBase-root-MuiIconButton-root"
data-mui-internal-clone-element="true"
tabindex="0"
Expand Down
2 changes: 1 addition & 1 deletion frontend/src/components/Sidebar/__snapshots__/Sidebar.HomeSidebarOpen.stories.storyshot
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -208,7 +208,7 @@
class="MuiBox-root css-s2uf1z"
>
<button
aria-label="Collapse Sidebar"
aria-label="Shrink sidebar"
class="MuiButtonBase-root MuiIconButton-root MuiIconButton-sizeSmall css-lr7sro-MuiButtonBase-root-MuiIconButton-root"
data-mui-internal-clone-element="true"
tabindex="0"
Expand Down
2 changes: 1 addition & 1 deletion ...end/src/components/Sidebar/__snapshots__/Sidebar.InClusterSidebarClosed.stories.storyshot
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1287,7 +1287,7 @@
class="MuiBox-root css-xi606m"
>
<button
aria-label="Collapse Sidebar"
aria-label="Expand sidebar"
class="MuiButtonBase-root MuiIconButton-root MuiIconButton-sizeSmall css-lr7sro-MuiButtonBase-root-MuiIconButton-root"
data-mui-internal-clone-element="true"
tabindex="0"
Expand Down
2 changes: 1 addition & 1 deletion frontend/src/components/Sidebar/__snapshots__/Sidebar.InClusterSidebarOpen.stories.storyshot
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1359,7 +1359,7 @@
class="MuiBox-root css-s2uf1z"
>
<button
aria-label="Collapse Sidebar"
aria-label="Shrink sidebar"
class="MuiButtonBase-root MuiIconButton-root MuiIconButton-sizeSmall css-lr7sro-MuiButtonBase-root-MuiIconButton-root"
data-mui-internal-clone-element="true"
tabindex="0"
Expand Down
2 changes: 1 addition & 1 deletion ...components/Sidebar/__snapshots__/Sidebar.SelectedItemWithSidebarOmitted.stories.storyshot
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1359,7 +1359,7 @@
class="MuiBox-root css-s2uf1z"
>
<button
aria-label="Collapse Sidebar"
aria-label="Shrink sidebar"
class="MuiButtonBase-root MuiIconButton-root MuiIconButton-sizeSmall css-lr7sro-MuiButtonBase-root-MuiIconButton-root"
data-mui-internal-clone-element="true"
tabindex="0"
Expand Down
1 change: 0 additions & 1 deletion frontend/src/i18n/locales/de/translation.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -452,7 +452,6 @@
"Expand sidebar": "Seitenleiste erweitern",
"Main Navigation": "Hauptnavigation",
"Navigation Tabs": "Navigationstabs",
"Collapse Sidebar": "Seitenleiste einklappen",
"Navigation": "Navigation",
"General": "",
"Clusters": "",
Expand Down
1 change: 0 additions & 1 deletion frontend/src/i18n/locales/en/translation.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -452,7 +452,6 @@
"Expand sidebar": "Expand sidebar",
"Main Navigation": "Main Navigation",
"Navigation Tabs": "Navigation Tabs",
"Collapse Sidebar": "Collapse Sidebar",
"Navigation": "Navigation",
"General": "General",
"Clusters": "Clusters",
Expand Down
1 change: 0 additions & 1 deletion frontend/src/i18n/locales/es/translation.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -453,7 +453,6 @@
"Expand sidebar": "Expandir barra lateral",
"Main Navigation": "Navegación principal",
"Navigation Tabs": "Pestañas de navegación",
"Collapse Sidebar": "Contraer barra lateral",
"Navigation": "Navegación",
"General": "General",
"Clusters": "",
Expand Down
1 change: 0 additions & 1 deletion frontend/src/i18n/locales/fr/translation.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -453,7 +453,6 @@
"Expand sidebar": "Développer la barre latérale",
"Main Navigation": "Navigation principale",
"Navigation Tabs": "Onglets de navigation",
"Collapse Sidebar": "Réduire la barre latérale",
"Navigation": "Navigation",
"General": "",
"Clusters": "",
Expand Down
1 change: 0 additions & 1 deletion frontend/src/i18n/locales/it/translation.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -453,7 +453,6 @@
"Expand sidebar": "Espandi barra laterale",
"Main Navigation": "Navigazione Principale",
"Navigation Tabs": "Schede di Navigazione",
"Collapse Sidebar": "Comprimi Barra Laterale",
"Navigation": "Navigazione",
"General": "Generale",
"Clusters": "",
Expand Down
1 change: 0 additions & 1 deletion frontend/src/i18n/locales/ja/translation.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -451,7 +451,6 @@
"Expand sidebar": "サイドバーを展開",
"Main Navigation": "メインナビゲーション",
"Navigation Tabs": "ナビゲーションタブ",
"Collapse Sidebar": "サイドバーを折りたたむ",
"Navigation": "ナビゲーション",
"General": "一般",
"Clusters": "",
Expand Down
1 change: 0 additions & 1 deletion frontend/src/i18n/locales/ko/translation.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -451,7 +451,6 @@
"Expand sidebar": "사이드바 확장",
"Main Navigation": "메인 탐색",
"Navigation Tabs": "탐색 탭",
"Collapse Sidebar": "사이드바 축소",
"Navigation": "Navigation",
"General": "일반",
"Clusters": "",
Expand Down
1 change: 0 additions & 1 deletion frontend/src/i18n/locales/pt/translation.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -453,7 +453,6 @@
"Expand sidebar": "Expandir barra lateral",
"Main Navigation": "Navegação Principal",
"Navigation Tabs": "Separadores de Navegação",
"Collapse Sidebar": "Encolher Barra Lateral",
"Navigation": "Navegação",
"General": "Geral",
"Clusters": "",
Expand Down
1 change: 0 additions & 1 deletion frontend/src/i18n/locales/zh-tw/translation.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -451,7 +451,6 @@
"Expand sidebar": "展開側邊欄",
"Main Navigation": "主導航",
"Navigation Tabs": "導航標籤",
"Collapse Sidebar": "折疊側邊欄",
"Navigation": "導航",
"General": "一般",
"Clusters": "",
Expand Down
1 change: 0 additions & 1 deletion frontend/src/i18n/locales/zh/translation.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -451,7 +451,6 @@
"Expand sidebar": "展开侧边栏",
"Main Navigation": "主导航",
"Navigation Tabs": "导航标签",
"Collapse Sidebar": "折叠侧边栏",
"Navigation": "导航",
"General": "一般",
"Clusters": "",
Expand Down