frontend: Sidebar: Fix conditional expansion description text

[Pratik-050]

Note for reviewers:

Changed the description of the left chevron and right chevron button in the sidebar.

fixes: #3276

Renamed Collapse sidebar to Shrink sidebar as the i18n support for Collapse Sidebar was there with a block 'S' but not the same for Expand Sidebar. Attached a screenshot of the translation.json for more context:

This is why some tests expecting Collapse Sidebar are failing as well.

[k8s-ci-robot]

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: Pratik-050
Once this PR has been reviewed and has the lgtm label, please assign sniok for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

• OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[illume]

Very cool. Thank you.

You can update the snapshot test with:
npm run test -- -u

We follow a linux kernel style of commit messages. With the context at the front followed by an action word and the rest.
Would you mind changing them to something like this?
frontend: Sidebar: Fix conditional expansion description text

[Pratik-050]

Thanks @illume I've updated the commit message and the tests as well. Thank you for your guidance!

[illume]

The check is failing...

Can you please run make frontend-i18n-check in the root of the repo and see what the problem is?

I see we already have t('Shrink sidebar') : t('Expand sidebar') in HeadlampButton.tsx... and in the translation.json files.

[eyeaadil]

Looking Good

[Pratik-050]

Hello @illume yes we have t('Shrink sidebar') : t('Expand sidebar') in HeadlampButton.tsx but that only changes a aria-label, I think that is for test purpose only.
This error is coming when I'm trying to run make make frontend-i18n-check

[illume]

After you run that command, then run

git status

… to see what files it has changed.

it might also be a good idea to git rebase against the latest main branch.

[Pratik-050]

I took a pull from the latest main just now and ran this command but no file changes are there. @illume

[illume]

Hrmm. Ok. Let me have a closer look in a little bit. If I find a fix I’ll push it to your branch.

[Pratik-050]

Thanks! @illume