Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[release-1.17] Update handling Capabilities that have a float value #5497

Merged
merged 1 commit into from
Mar 20, 2025
Merged

[release-1.17] Update handling Capabilities that have a float value #5497

merged 1 commit into from
Mar 20, 2025

Conversation

nawazkh
Copy link
Member

@nawazkh nawazkh commented Mar 20, 2025

This is an manual cherry-pick of #5481

/assign nawazkh

Update handling of AzureMachine's `VMSize` Capabilities that have a float value

Creating this PR since the automated cherry-picked PR #5492 is blocked on linter errors.

@sadasu @nawazkh
Update handling Capabilities that have a float value
2115e43 
In the case of "Standard_M8-4ms", their memory capability is
specified as a float with value 218.75 GiB.

Added a fix to handle capabilitites that have a float value instead
of erroring from reconcile because of inability to parse float values.
@k8s-ci-robot k8s-ci-robot added the release-note Denotes a PR that will be considered when it comes time to generate release notes. label Mar 20, 2025
@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Mar 20, 2025
@nawazkh nawazkh mentioned this pull request Mar 20, 2025
Closed
@codecov Codecov
Copy link

codecov bot commented Mar 20, 2025 •
edited
Loading

Codecov Report

Attention: Patch coverage is 0% with 3 lines in your changes missing coverage. Please review.

Project coverage is 52.40%. Comparing base (85a1d00) to head (2115e43).
Report is 5 commits behind head on release-1.17.

Files with missing lines Patch % Lines
azure/services/resourceskus/sku.go 0.00% 3 Missing ⚠️
Additional details and impacted files 
@@              Coverage Diff              @@
##           release-1.17    #5497   +/-   ##
=============================================
  Coverage         52.39%   52.40%           
=============================================
  Files               273      273           
  Lines             29189    29191    +2     
=============================================
+ Hits              15295    15297    +2     
  Misses            13093    13093           
  Partials            801      801

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@nawazkh
Copy link
Member Author

nawazkh commented Mar 20, 2025

I ran pull-cluster-api-provider-azure-test-v1beta1 prow job locally and it is passing.
The effort needed to update golangci-lint for release-1.17 isnt outweighs the benefits, let's merge this PR. Release-1.17 is nearing EOL with release-1.19 around the corner.
@willie-yao @Jont828 What say ?

❯ ./scripts/ci-test.sh
make: Entering directory '/home/nhkdev/msftcode/cluster-api-provider-azure'
make generate-go
make[1]: Entering directory '/home/nhkdev/msftcode/cluster-api-provider-azure'
GOBIN=/home/nhkdev/msftcode/cluster-api-provider-azure/hack/tools/bin ./scripts/go_install.sh sigs.k8s.io/controller-tools/cmd/controller-gen controller-gen v0.15.0
go: downloading sigs.k8s.io/controller-tools v0.15.0
go: downloading golang.org/x/tools v0.20.0
go: downloading k8s.io/api v0.30.0
go: downloading k8s.io/apimachinery v0.30.0
go: downloading k8s.io/apiextensions-apiserver v0.30.0
go: downloading k8s.io/klog/v2 v2.120.1
go: downloading golang.org/x/sys v0.19.0
go: downloading golang.org/x/net v0.24.0
GOBIN=/home/nhkdev/msftcode/cluster-api-provider-azure/hack/tools/bin ./scripts/go_install.sh k8s.io/code-generator/cmd/conversion-gen conversion-gen v0.30.0
go: downloading k8s.io/code-generator v0.30.0
go: downloading golang.org/x/tools v0.18.0
go: downloading golang.org/x/mod v0.15.0
/home/nhkdev/msftcode/cluster-api-provider-azure/hack/tools/bin/controller-gen-v0.15.0 \
	paths=./api/... \
	paths=./exp/api/... \
	object:headerFile=./hack/boilerplate/boilerplate.generatego.txt
go generate ./...
make[1]: Leaving directory '/home/nhkdev/msftcode/cluster-api-provider-azure'
make generate-manifests
make[1]: Entering directory '/home/nhkdev/msftcode/cluster-api-provider-azure'
/home/nhkdev/msftcode/cluster-api-provider-azure/hack/tools/bin/controller-gen-v0.15.0 \
	paths=./api/... \
	paths=./exp/api/... \
	crd:crdVersions=v1 \
	rbac:roleName=base-manager-role \
	output:crd:dir=config/crd/bases \
	output:webhook:dir=config/webhook \
	webhook
/home/nhkdev/msftcode/cluster-api-provider-azure/hack/tools/bin/controller-gen-v0.15.0 \
	paths=./ \
	paths=./controllers/... \
	paths=./exp/controllers/... \
	output:rbac:dir=config/rbac \
	rbac:roleName=base-manager-role
make[1]: Leaving directory '/home/nhkdev/msftcode/cluster-api-provider-azure'
make generate-flavors
make[1]: Entering directory '/home/nhkdev/msftcode/cluster-api-provider-azure'
cp /home/nhkdev/msftcode/cluster-api-provider-azure/_artifacts/calico/release-v3.26.1/manifests/calico-vxlan.yaml templates/addons/calico
cp /home/nhkdev/msftcode/cluster-api-provider-azure/_artifacts/calico/release-v3.26.1/manifests/calico-policy-only.yaml templates/addons/calico-ipv6
/home/nhkdev/msftcode/cluster-api-provider-azure/hack/tools/bin/kustomize-v5.4.1 build templates/addons/metrics-server > templates/addons/metrics-server/metrics-server.yaml
/home/nhkdev/msftcode/cluster-api-provider-azure/hack/tools/bin/kustomize-v5.4.1 build templates/addons/calico > templates/addons/calico.yaml
/home/nhkdev/msftcode/cluster-api-provider-azure/hack/tools/bin/kustomize-v5.4.1 build templates/addons/calico-ipv6 > templates/addons/calico-ipv6.yaml
/home/nhkdev/msftcode/cluster-api-provider-azure/hack/tools/bin/kustomize-v5.4.1 build templates/addons/calico-dual-stack > templates/addons/calico-dual-stack.yaml
/home/nhkdev/msftcode/cluster-api-provider-azure/hack/tools/bin/kustomize-v5.4.1 build templates/addons/azure-cni-v1 > templates/addons/azure-cni-v1.yaml
./hack/gen-flavors.sh
make[2]: Entering directory '/home/nhkdev/msftcode/cluster-api-provider-azure'
make[2]: Nothing to be done for 'kustomize'.
make[2]: Leaving directory '/home/nhkdev/msftcode/cluster-api-provider-azure'
make[1]: Leaving directory '/home/nhkdev/msftcode/cluster-api-provider-azure'
make generate-e2e-templates
make[1]: Entering directory '/home/nhkdev/msftcode/cluster-api-provider-azure'
/home/nhkdev/msftcode/cluster-api-provider-azure/hack/tools/bin/kustomize-v5.4.1 build /home/nhkdev/msftcode/cluster-api-provider-azure/test/e2e/data/infrastructure-azure/v1beta1/cluster-template --load-restrictor LoadRestrictionsNone > /home/nhkdev/msftcode/cluster-api-provider-azure/test/e2e/data/infrastructure-azure/v1beta1/cluster-template.yaml
/home/nhkdev/msftcode/cluster-api-provider-azure/hack/tools/bin/kustomize-v5.4.1 build /home/nhkdev/msftcode/cluster-api-provider-azure/test/e2e/data/infrastructure-azure/v1beta1/cluster-template-md-remediation --load-restrictor LoadRestrictionsNone > /home/nhkdev/msftcode/cluster-api-provider-azure/test/e2e/data/infrastructure-azure/v1beta1/cluster-template-md-remediation.yaml
/home/nhkdev/msftcode/cluster-api-provider-azure/hack/tools/bin/kustomize-v5.4.1 build /home/nhkdev/msftcode/cluster-api-provider-azure/test/e2e/data/infrastructure-azure/v1beta1/cluster-template-kcp-remediation --load-restrictor LoadRestrictionsNone > /home/nhkdev/msftcode/cluster-api-provider-azure/test/e2e/data/infrastructure-azure/v1beta1/cluster-template-kcp-remediation.yaml
/home/nhkdev/msftcode/cluster-api-provider-azure/hack/tools/bin/kustomize-v5.4.1 build /home/nhkdev/msftcode/cluster-api-provider-azure/test/e2e/data/infrastructure-azure/v1beta1/cluster-template-machine-pool --load-restrictor LoadRestrictionsNone > /home/nhkdev/msftcode/cluster-api-provider-azure/test/e2e/data/infrastructure-azure/v1beta1/cluster-template-machine-pool.yaml
/home/nhkdev/msftcode/cluster-api-provider-azure/hack/tools/bin/kustomize-v5.4.1 build /home/nhkdev/msftcode/cluster-api-provider-azure/test/e2e/data/infrastructure-azure/v1beta1/cluster-template-node-drain --load-restrictor LoadRestrictionsNone > /home/nhkdev/msftcode/cluster-api-provider-azure/test/e2e/data/infrastructure-azure/v1beta1/cluster-template-node-drain.yaml
/home/nhkdev/msftcode/cluster-api-provider-azure/hack/tools/bin/kustomize-v5.4.1 build /home/nhkdev/msftcode/cluster-api-provider-azure/test/e2e/data/infrastructure-azure/v1beta1/cluster-template-upgrades --load-restrictor LoadRestrictionsNone > /home/nhkdev/msftcode/cluster-api-provider-azure/test/e2e/data/infrastructure-azure/v1beta1/cluster-template-upgrades.yaml
/home/nhkdev/msftcode/cluster-api-provider-azure/hack/tools/bin/kustomize-v5.4.1 build /home/nhkdev/msftcode/cluster-api-provider-azure/test/e2e/data/infrastructure-azure/v1beta1/cluster-template-kcp-scale-in --load-restrictor LoadRestrictionsNone > /home/nhkdev/msftcode/cluster-api-provider-azure/test/e2e/data/infrastructure-azure/v1beta1/cluster-template-kcp-scale-in.yaml
make[1]: Leaving directory '/home/nhkdev/msftcode/cluster-api-provider-azure'
make generate-addons
make[1]: Entering directory '/home/nhkdev/msftcode/cluster-api-provider-azure'
cp /home/nhkdev/msftcode/cluster-api-provider-azure/_artifacts/calico/release-v3.26.1/manifests/calico-vxlan.yaml templates/addons/calico
cp /home/nhkdev/msftcode/cluster-api-provider-azure/_artifacts/calico/release-v3.26.1/manifests/calico-policy-only.yaml templates/addons/calico-ipv6
/home/nhkdev/msftcode/cluster-api-provider-azure/hack/tools/bin/kustomize-v5.4.1 build templates/addons/metrics-server > templates/addons/metrics-server/metrics-server.yaml
/home/nhkdev/msftcode/cluster-api-provider-azure/hack/tools/bin/kustomize-v5.4.1 build templates/addons/calico > templates/addons/calico.yaml
/home/nhkdev/msftcode/cluster-api-provider-azure/hack/tools/bin/kustomize-v5.4.1 build templates/addons/calico-ipv6 > templates/addons/calico-ipv6.yaml
/home/nhkdev/msftcode/cluster-api-provider-azure/hack/tools/bin/kustomize-v5.4.1 build templates/addons/calico-dual-stack > templates/addons/calico-dual-stack.yaml
/home/nhkdev/msftcode/cluster-api-provider-azure/hack/tools/bin/kustomize-v5.4.1 build templates/addons/azure-cni-v1 > templates/addons/azure-cni-v1.yaml
make[1]: Leaving directory '/home/nhkdev/msftcode/cluster-api-provider-azure'
make generate-aso-crds
make[1]: Entering directory '/home/nhkdev/msftcode/cluster-api-provider-azure'
curl -fSsL "https://github.com/Azure/azure-service-operator/releases/download/v2.8.0/azureserviceoperator_customresourcedefinitions_v2.8.0.yaml" | \
	/home/nhkdev/msftcode/cluster-api-provider-azure/hack/tools/bin/yq-v4.35.2 e '. | select(.metadata.name == "resourcegroups.resources.azure.com" or  .metadata.name == "natgateways.network.azure.com" or  .metadata.name == "managedclusters.containerservice.azure.com" or  .metadata.name == "managedclustersagentpools.containerservice.azure.com" or  .metadata.name == "bastionhosts.network.azure.com" or  .metadata.name == "virtualnetworks.network.azure.com" or  .metadata.name == "virtualnetworkssubnets.network.azure.com" or  .metadata.name == "privateendpoints.network.azure.com" or  .metadata.name == "fleetsmembers.containerservice.azure.com" or  .metadata.name == "extensions.kubernetesconfiguration.azure.com" or false)' - | \
	sed 's/\$\$/$$$$/g' \
	> config/aso/crds.yaml
make[1]: Leaving directory '/home/nhkdev/msftcode/cluster-api-provider-azure'
GOBIN=/home/nhkdev/msftcode/cluster-api-provider-azure/hack/tools/bin ./scripts/go_install.sh github.com/golangci/golangci-lint/cmd/golangci-lint golangci-lint v1.55.2
go: downloading github.com/golangci/golangci-lint v1.55.2
go: downloading github.com/gofrs/flock v0.8.1
go: downloading golang.org/x/tools v0.14.0
go: downloading github.com/hashicorp/go-version v1.6.0
go: downloading github.com/ldez/gomoddirectives v0.2.3
go: downloading golang.org/x/exp v0.0.0-20230510235704-dd950f8aeaea
go: downloading github.com/hashicorp/go-multierror v1.1.1
go: downloading github.com/spf13/afero v1.8.2
go: downloading github.com/golangci/revgrep v0.5.2
go: downloading golang.org/x/sys v0.13.0
go: downloading github.com/stretchr/objx v0.5.0
go: downloading github.com/4meepo/tagalign v1.3.3
go: downloading github.com/Abirdcfly/dupword v0.0.13
go: downloading github.com/Antonboom/errname v0.1.12
go: downloading github.com/Antonboom/nilnil v0.1.7
go: downloading github.com/Antonboom/testifylint v0.2.3
go: downloading github.com/BurntSushi/toml v1.3.2
go: downloading github.com/GaijinEntertainment/go-exhaustruct/v3 v3.1.0
go: downloading github.com/OpenPeeDeeP/depguard/v2 v2.1.0
go: downloading github.com/alecthomas/go-check-sumtype v0.1.3
go: downloading github.com/alexkohler/nakedret/v2 v2.0.2
go: downloading github.com/bombsimon/wsl/v3 v3.4.0
go: downloading github.com/butuzov/ireturn v0.2.2
go: downloading github.com/butuzov/mirror v1.1.0
go: downloading github.com/catenacyber/perfsprint v0.2.0
go: downloading github.com/daixiang0/gci v0.11.2
go: downloading github.com/denis-tingaikin/go-header v0.4.3
go: downloading github.com/esimonov/ifshort v1.0.4
go: downloading github.com/firefart/nonamedreturns v1.0.4
go: downloading github.com/ghostiam/protogetter v0.2.3
go: downloading github.com/go-critic/go-critic v0.9.0
go: downloading github.com/golangci/check v0.0.0-20180506172741-cfe4005ccda2
go: downloading github.com/golangci/go-misc v0.0.0-20220329215616-d24fe342adfe
go: downloading github.com/golangci/gofmt v0.0.0-20231018234816-f50ced29576e
go: downloading github.com/golangci/lint-1 v0.0.0-20191013205115-297bf364a8e0
go: downloading github.com/golangci/maligned v0.0.0-20180506175553-b1d89398deca
go: downloading github.com/golangci/misspell v0.4.1
go: downloading github.com/golangci/unconvert v0.0.0-20180507085042-28b1c447d1f4
go: downloading github.com/gordonklaus/ineffassign v0.0.0-20230610083614-0e73809eb601
go: downloading github.com/jgautheron/goconst v1.6.0
go: downloading github.com/kisielk/errcheck v1.6.3
go: downloading github.com/kkHAIKE/contextcheck v1.1.4
go: downloading github.com/kunwardeep/paralleltest v1.0.8
go: downloading github.com/leonklingele/grouper v1.1.1
go: downloading github.com/macabu/inamedparam v0.1.2
go: downloading github.com/mbilski/exhaustivestruct v1.2.0
go: downloading github.com/mgechev/revive v1.3.4
go: downloading github.com/moricho/tparallel v0.3.1
go: downloading github.com/nishanths/exhaustive v0.11.0
go: downloading github.com/nunnatsa/ginkgolinter v0.14.1
go: downloading github.com/polyfloyd/go-errorlint v1.4.5
go: downloading github.com/ryancurrah/gomodguard v1.3.0
go: downloading github.com/sashamelentyev/usestdlibvars v1.24.0
go: downloading github.com/securego/gosec/v2 v2.18.2
go: downloading github.com/sivchari/nosnakecase v1.7.0
go: downloading github.com/sivchari/tenv v1.7.1
go: downloading github.com/tetafro/godot v1.4.15
go: downloading github.com/tomarrell/wrapcheck/v2 v2.8.1
go: downloading github.com/ultraware/whitespace v0.0.5
go: downloading github.com/uudashr/gocognit v1.1.2
go: downloading github.com/yeya24/promlinter v0.2.0
go: downloading github.com/ykadowak/zerologlint v0.1.3
go: downloading gitlab.com/bosi/decorder v0.4.1
go: downloading go-simpler.org/sloglint v0.1.2
go: downloading go.tmz.dev/musttag v0.7.2
go: downloading honnef.co/go/tools v0.4.6
go: downloading mvdan.cc/gofumpt v0.5.0
go: downloading mvdan.cc/interfacer v0.0.0-20180901003855-c20040233aed
go: downloading mvdan.cc/unparam v0.0.0-20221223090309-7455f1af531d
go: downloading golang.org/x/mod v0.13.0
go: downloading github.com/pelletier/go-toml/v2 v2.0.5
go: downloading github.com/hashicorp/errwrap v1.0.0
go: downloading golang.org/x/sync v0.4.0
go: downloading github.com/go-toolsmith/astequal v1.1.0
go: downloading github.com/quasilyte/go-ruleguard v0.4.0
go: downloading github.com/ettle/strcase v0.1.1
go: downloading github.com/kisielk/gotool v1.0.0
go: downloading github.com/Masterminds/semver v1.5.0
go: downloading github.com/ccojocar/zxcvbn-go v1.0.1
go: downloading golang.org/x/exp/typeparams v0.0.0-20230307190834-24139beb5833
go: downloading mvdan.cc/lint v0.0.0-20170908181259-adc824a0674b
go: downloading github.com/golang/protobuf v1.5.2
go: downloading google.golang.org/protobuf v1.28.0
./hack/lint-latest.sh
/home/nhkdev/msftcode/cluster-api-provider-azure/hack/tools/bin/golangci-lint-v1.55.2 run -v --timeout=8m0s --print-resources-usage
INFO [config_reader] Config search paths: [./ /home/nhkdev/msftcode/cluster-api-provider-azure /home/nhkdev/msftcode /home/nhkdev /home /]
INFO [config_reader] Used config file .golangci.yml
INFO [lintersdb] Active 47 linters: [asasalint asciicheck bidichk bodyclose containedctx decorder dogsled dupword durationcheck errcheck errchkjson errorlint execinquery exportloopref gci ginkgolinter goconst gocritic gocyclo godot gofmt goimports goprintffuncname gosec gosimple govet importas ineffassign loggercheck misspell nakedret nilerr noctx nolintlint nosprintfhostport predeclared reassign revive rowserrcheck staticcheck stylecheck thelper unconvert unparam unused usestdlibvars whitespace]
INFO [loader] Using build tags: [e2e]
INFO [loader] Go packages loading at mode 575 (types_sizes|compiled_files|imports|name|deps|exports_file|files) took 1m50.483568257s
INFO [runner/filename_unadjuster] Pre-built 0 adjustments in 75.057101ms
INFO [linters_context/goanalysis] analyzers took 16m18.166967716s with top 10 stages: buildir: 6m23.665164367s, gocritic: 5m11.947069444s, buildssa: 46.094923454s, nilness: 16.957062296s, the_only_name: 15.731996992s, unconvert: 13.960519785s, goimports: 12.528994011s, gci: 12.121492918s, printf: 8.331591721s, fact_purity: 7.002810197s
INFO [runner] Issues before processing: 666, after processing: 0
INFO [runner] Processors filtering stat (out/in): autogenerated_exclude: 600/659, path_prettifier: 666/666, nolint: 0/48, skip_dirs: 659/659, identifier_marker: 600/600, exclude: 600/600, cgo: 666/666, filename_unadjuster: 666/666, skip_files: 659/666, exclude-rules: 48/600
INFO [runner] processing took 64.066093ms with stages: nolint: 20.382047ms, exclude-rules: 17.693104ms, identifier_marker: 10.304831ms, autogenerated_exclude: 8.140289ms, path_prettifier: 5.939853ms, skip_dirs: 1.414375ms, skip_files: 98.417µs, cgo: 57.31µs, filename_unadjuster: 29.224µs, max_same_issues: 1.518µs, uniq_by_line: 794ns, diff: 779ns, source_code: 670ns, sort_results: 530ns, fixer: 500ns, exclude: 492ns, max_from_linter: 418ns, severity-rules: 369ns, path_prefixer: 248ns, max_per_file_from_linter: 163ns, path_shortener: 162ns
INFO [runner] linters took 1m35.78982759s with stages: goanalysis_metalinter: 1m35.725617888s
INFO File cache stats: 587 entries of total size 5.0MiB
INFO Memory: 1804 samples, avg is 1530.6MB, max is 7192.8MB
INFO Execution took 3m26.362868192s
GOBIN=/home/nhkdev/msftcode/cluster-api-provider-azure/hack/tools/bin ./scripts/go_install.sh sigs.k8s.io/controller-runtime/tools/setup-envtest setup-envtest v0.0.0-20240522175850-2e9781e9fc60
go: downloading sigs.k8s.io/controller-runtime/tools/setup-envtest v0.0.0-20240522175850-2e9781e9fc60
go: downloading sigs.k8s.io/controller-runtime v0.0.0-20240522175850-2e9781e9fc60
go: downloading sigs.k8s.io/yaml v1.3.0
KUBEBUILDER_ASSETS="/home/nhkdev/.local/share/kubebuilder-envtest/k8s/1.31.0-linux-amd64" go test ./... -race
?   	sigs.k8s.io/cluster-api-provider-azure	[no test files]
?   	sigs.k8s.io/cluster-api-provider-azure/api/v1alpha1	[no test files]
?   	sigs.k8s.io/cluster-api-provider-azure/azure/mock_azure	[no test files]
?   	sigs.k8s.io/cluster-api-provider-azure/azure/scope/mocks	[no test files]
?   	sigs.k8s.io/cluster-api-provider-azure/azure/services/agentpools/mock_agentpools	[no test files]
?   	sigs.k8s.io/cluster-api-provider-azure/azure/services/aso/mock_aso	[no test files]
?   	sigs.k8s.io/cluster-api-provider-azure/azure/services/async/mock_async	[no test files]
?   	sigs.k8s.io/cluster-api-provider-azure/azure/services/availabilitysets/mock_availabilitysets	[no test files]
?   	sigs.k8s.io/cluster-api-provider-azure/azure/services/disks/mock_disks	[no test files]
?   	sigs.k8s.io/cluster-api-provider-azure/azure/services/groups/mock_groups	[no test files]
?   	sigs.k8s.io/cluster-api-provider-azure/azure/services/identities	[no test files]
?   	sigs.k8s.io/cluster-api-provider-azure/azure/services/identities/mock_identities	[no test files]
ok  	sigs.k8s.io/cluster-api-provider-azure/api/v1beta1	26.703s
ok  	sigs.k8s.io/cluster-api-provider-azure/azure	1.119s
ok  	sigs.k8s.io/cluster-api-provider-azure/azure/converters	1.198s
ok  	sigs.k8s.io/cluster-api-provider-azure/azure/scope	1.444s
ok  	sigs.k8s.io/cluster-api-provider-azure/azure/scope/strategies/machinepool_deployments	1.131s
ok  	sigs.k8s.io/cluster-api-provider-azure/azure/services/agentpools	1.170s
ok  	sigs.k8s.io/cluster-api-provider-azure/azure/services/aksextensions	1.175s
ok  	sigs.k8s.io/cluster-api-provider-azure/azure/services/aso	1.247s
ok  	sigs.k8s.io/cluster-api-provider-azure/azure/services/async	1.162s
ok  	sigs.k8s.io/cluster-api-provider-azure/azure/services/availabilitysets	1.222s
ok  	sigs.k8s.io/cluster-api-provider-azure/azure/services/bastionhosts	1.223s
ok  	sigs.k8s.io/cluster-api-provider-azure/azure/services/disks	1.125s
ok  	sigs.k8s.io/cluster-api-provider-azure/azure/services/fleetsmembers	1.163s
ok  	sigs.k8s.io/cluster-api-provider-azure/azure/services/groups	1.174s
?   	sigs.k8s.io/cluster-api-provider-azure/azure/services/inboundnatrules/mock_inboundnatrules	[no test files]
?   	sigs.k8s.io/cluster-api-provider-azure/azure/services/loadbalancers/mock_loadbalancers	[no test files]
?   	sigs.k8s.io/cluster-api-provider-azure/azure/services/managedclusters/mock_managedclusters	[no test files]
?   	sigs.k8s.io/cluster-api-provider-azure/azure/services/natgateways/mock_natgateways	[no test files]
ok  	sigs.k8s.io/cluster-api-provider-azure/azure/services/inboundnatrules	1.118s
ok  	sigs.k8s.io/cluster-api-provider-azure/azure/services/loadbalancers	1.155s
ok  	sigs.k8s.io/cluster-api-provider-azure/azure/services/managedclusters	1.208s
ok  	sigs.k8s.io/cluster-api-provider-azure/azure/services/natgateways	1.145s
?   	sigs.k8s.io/cluster-api-provider-azure/azure/services/networkinterfaces/mock_networkinterfaces	[no test files]
?   	sigs.k8s.io/cluster-api-provider-azure/azure/services/privatedns/mock_privatedns	[no test files]
?   	sigs.k8s.io/cluster-api-provider-azure/azure/services/privateendpoints/mock_privateendpoints	[no test files]
ok  	sigs.k8s.io/cluster-api-provider-azure/azure/services/networkinterfaces	1.182s
ok  	sigs.k8s.io/cluster-api-provider-azure/azure/services/privatedns	1.174s
ok  	sigs.k8s.io/cluster-api-provider-azure/azure/services/privateendpoints	1.185s
?   	sigs.k8s.io/cluster-api-provider-azure/azure/services/publicips/mock_publicips	[no test files]
ok  	sigs.k8s.io/cluster-api-provider-azure/azure/services/publicips	1.133s
?   	sigs.k8s.io/cluster-api-provider-azure/azure/services/resourcehealth/mock_resourcehealth	[no test files]
?   	sigs.k8s.io/cluster-api-provider-azure/azure/services/resourceskus/mock_resourceskus	[no test files]
ok  	sigs.k8s.io/cluster-api-provider-azure/azure/services/resourcehealth	1.126s
ok  	sigs.k8s.io/cluster-api-provider-azure/azure/services/resourceskus	1.106s
?   	sigs.k8s.io/cluster-api-provider-azure/azure/services/roleassignments/mock_roleassignments	[no test files]
ok  	sigs.k8s.io/cluster-api-provider-azure/azure/services/roleassignments	1.128s
?   	sigs.k8s.io/cluster-api-provider-azure/azure/services/routetables/mock_routetables	[no test files]
?   	sigs.k8s.io/cluster-api-provider-azure/azure/services/scalesets/mock_scalesets	[no test files]
?   	sigs.k8s.io/cluster-api-provider-azure/azure/services/scalesetvms/mock_scalesetvms	[no test files]
ok  	sigs.k8s.io/cluster-api-provider-azure/azure/services/routetables	1.186s
ok  	sigs.k8s.io/cluster-api-provider-azure/azure/services/scalesets	1.203s
ok  	sigs.k8s.io/cluster-api-provider-azure/azure/services/scalesetvms	1.196s
?   	sigs.k8s.io/cluster-api-provider-azure/azure/services/securitygroups/mock_securitygroups	[no test files]
?   	sigs.k8s.io/cluster-api-provider-azure/azure/services/subnets/mock_subnets	[no test files]
?   	sigs.k8s.io/cluster-api-provider-azure/azure/services/tags/mock_tags	[no test files]
?   	sigs.k8s.io/cluster-api-provider-azure/azure/services/virtualmachineimages/mock_virtualmachineimages	[no test files]
ok  	sigs.k8s.io/cluster-api-provider-azure/azure/services/securitygroups	1.183s
ok  	sigs.k8s.io/cluster-api-provider-azure/azure/services/subnets	1.189s
ok  	sigs.k8s.io/cluster-api-provider-azure/azure/services/tags	1.148s
ok  	sigs.k8s.io/cluster-api-provider-azure/azure/services/virtualmachineimages	1.140s
?   	sigs.k8s.io/cluster-api-provider-azure/azure/services/virtualmachines/mock_virtualmachines	[no test files]
?   	sigs.k8s.io/cluster-api-provider-azure/azure/services/virtualnetworks/mock_virtualnetworks	[no test files]
?   	sigs.k8s.io/cluster-api-provider-azure/azure/services/vmextensions/mock_vmextensions	[no test files]
ok  	sigs.k8s.io/cluster-api-provider-azure/azure/services/virtualmachines	1.151s
ok  	sigs.k8s.io/cluster-api-provider-azure/azure/services/virtualnetworks	1.171s
ok  	sigs.k8s.io/cluster-api-provider-azure/azure/services/vmextensions	1.139s
?   	sigs.k8s.io/cluster-api-provider-azure/azure/services/vnetpeerings/mock_vnetpeerings	[no test files]
ok  	sigs.k8s.io/cluster-api-provider-azure/azure/services/vnetpeerings	1.142s
?   	sigs.k8s.io/cluster-api-provider-azure/exp	[no test files]
?   	sigs.k8s.io/cluster-api-provider-azure/exp/controllers/mocks	[no test files]
?   	sigs.k8s.io/cluster-api-provider-azure/feature	[no test files]
?   	sigs.k8s.io/cluster-api-provider-azure/hack/boilerplate/test	[no test files]
?   	sigs.k8s.io/cluster-api-provider-azure/internal/test	[no test files]
?   	sigs.k8s.io/cluster-api-provider-azure/internal/test/matchers/gomock	[no test files]
?   	sigs.k8s.io/cluster-api-provider-azure/internal/test/mock_log	[no test files]
?   	sigs.k8s.io/cluster-api-provider-azure/internal/test/record	[no test files]
?   	sigs.k8s.io/cluster-api-provider-azure/pkg/cloudtest	[no test files]
?   	sigs.k8s.io/cluster-api-provider-azure/pkg/coalescing/mocks	[no test files]
?   	sigs.k8s.io/cluster-api-provider-azure/pkg/ot	[no test files]
?   	sigs.k8s.io/cluster-api-provider-azure/pkg/record	[no test files]
?   	sigs.k8s.io/cluster-api-provider-azure/util/aso	[no test files]
?   	sigs.k8s.io/cluster-api-provider-azure/util/cache/ttllru/mocks	[no test files]
?   	sigs.k8s.io/cluster-api-provider-azure/util/generators	[no test files]
?   	sigs.k8s.io/cluster-api-provider-azure/util/identity	[no test files]
?   	sigs.k8s.io/cluster-api-provider-azure/util/slice	[no test files]
ok  	sigs.k8s.io/cluster-api-provider-azure/controllers	10.223s
ok  	sigs.k8s.io/cluster-api-provider-azure/exp/api/v1beta1	7.720s
ok  	sigs.k8s.io/cluster-api-provider-azure/exp/controllers	8.700s
ok  	sigs.k8s.io/cluster-api-provider-azure/internal/test/env	1.159s
ok  	sigs.k8s.io/cluster-api-provider-azure/internal/test/matchers/gomega	1.041s
ok  	sigs.k8s.io/cluster-api-provider-azure/pkg/coalescing	1.086s
ok  	sigs.k8s.io/cluster-api-provider-azure/pkg/mutators	1.307s
?   	sigs.k8s.io/cluster-api-provider-azure/version	[no test files]
ok  	sigs.k8s.io/cluster-api-provider-azure/util/azure	5.087s
ok  	sigs.k8s.io/cluster-api-provider-azure/util/cache/ttllru	1.029s
ok  	sigs.k8s.io/cluster-api-provider-azure/util/futures	1.126s
ok  	sigs.k8s.io/cluster-api-provider-azure/util/maps	1.027s
ok  	sigs.k8s.io/cluster-api-provider-azure/util/reconciler	1.027s
ok  	sigs.k8s.io/cluster-api-provider-azure/util/ssh	1.243s
ok  	sigs.k8s.io/cluster-api-provider-azure/util/system	1.024s
ok  	sigs.k8s.io/cluster-api-provider-azure/util/tele	1.019s
ok  	sigs.k8s.io/cluster-api-provider-azure/util/versions	1.020s
ok  	sigs.k8s.io/cluster-api-provider-azure/util/webhook	1.027s
make: Leaving directory '/home/nhkdev/msftcode/cluster-api-provider-azure'

willie-yao
willie-yao approved these changes Mar 20, 2025
View reviewed changes
Copy link
Contributor

@willie-yao willie-yao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Mar 20, 2025
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: willie-yao

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Mar 20, 2025
@k8s-ci-robot
Copy link
Contributor

LGTM label has been added.

Git tree hash: 3cce9717b8c5538deffd9b217385bb0caabfb429

@willie-yao
Copy link
Contributor

Agreed! Don't worry about the linter

@k8s-ci-robot
Copy link
Contributor

k8s-ci-robot commented Mar 20, 2025 •
edited
Loading

@nawazkh: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
pull-cluster-api-provider-azure-test-v1beta1 2115e43 link true /test pull-cluster-api-provider-azure-test-v1beta1

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@nawazkh
Copy link
Member Author

nawazkh commented Mar 20, 2025

/test pull-cluster-api-provider-azure-e2e-v1beta1

@nawazkh nawazkh merged commit 9ba661b into kubernetes-sigs:release-1.17 Mar 20, 2025
16 of 18 checks passed
@nawazkh nawazkh deleted the handle_float_vm_memory branch March 20, 2025 23:22
sadasu added a commit to sadasu/installer that referenced this pull request Mar 26, 2025
@sadasu
Update cluster-api-provider-azure to release-1.17.5
7d27244 
This will bring in the fix:
kubernetes-sigs/cluster-api-provider-azure#5497
@sadasu sadasu mentioned this pull request Apr 1, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@willie-yao willie-yao willie-yao approved these changes

@Jont828 Jont828 Awaiting requested review from Jont828

@mboersma mboersma Awaiting requested review from mboersma

Assignees

@nawazkh nawazkh

@willie-yao willie-yao

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. release-note Denotes a PR that will be considered when it comes time to generate release notes. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
CAPZ Planning
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@nawazkh @k8s-ci-robot @willie-yao @sadasu