Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[release-1.17] Update handling Capabilities that have a float value #5492

Closed
wants to merge 1 commit into from
Closed

[release-1.17] Update handling Capabilities that have a float value #5492

wants to merge 1 commit into from

Conversation

k8s-infra-cherrypick-robot
Copy link

This is an automated cherry-pick of #5481

/assign nawazkh

Update handling of AzureMachine's `VMSize` Capabilities that have a float value

@sadasu
Update handling Capabilities that have a float value
3c6f236 
In the case of "Standard_M8-4ms", their memory capability is
specified as a float with value 218.75 GiB.

Added a fix to handle capabilitites that have a float value instead
of erroring from reconcile because of inability to parse float values.
@k8s-infra-cherrypick-robot k8s-infra-cherrypick-robot mentioned this pull request Mar 19, 2025
Merged
4 tasks
@k8s-ci-robot k8s-ci-robot added release-note Denotes a PR that will be considered when it comes time to generate release notes. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Mar 19, 2025
@k8s-ci-robot k8s-ci-robot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Mar 19, 2025
@nawazkh
Copy link
Member

nawazkh commented Mar 19, 2025

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Mar 19, 2025
@k8s-ci-robot
Copy link
Contributor

LGTM label has been added.

Git tree hash: 3cce9717b8c5538deffd9b217385bb0caabfb429

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: nawazkh
Once this PR has been reviewed and has the lgtm label, please assign jont828 for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@codecov Codecov
Copy link

codecov bot commented Mar 19, 2025 •
edited
Loading

Codecov Report

Attention: Patch coverage is 0% with 3 lines in your changes missing coverage. Please review.

Project coverage is 52.40%. Comparing base (85a1d00) to head (3c6f236).
Report is 3 commits behind head on release-1.17.

Files with missing lines Patch % Lines
azure/services/resourceskus/sku.go 0.00% 3 Missing ⚠️
Additional details and impacted files 
@@              Coverage Diff              @@
##           release-1.17    #5492   +/-   ##
=============================================
  Coverage         52.39%   52.40%           
=============================================
  Files               273      273           
  Lines             29189    29191    +2     
=============================================
+ Hits              15295    15297    +2     
  Misses            13093    13093           
  Partials            801      801

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@nawazkh
Copy link
Member

nawazkh commented Mar 19, 2025

/test pull-cluster-api-provider-azure-test-v1beta1

@k8s-ci-robot
Copy link
Contributor

@k8s-infra-cherrypick-robot: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
pull-cluster-api-provider-azure-test-v1beta1 3c6f236 link true /test pull-cluster-api-provider-azure-test-v1beta1
pull-cluster-api-provider-azure-e2e-v1beta1 3c6f236 link true /test pull-cluster-api-provider-azure-e2e-v1beta1

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@nawazkh
Copy link
Member

nawazkh commented Mar 20, 2025

/test pull-cluster-api-provider-azure-e2e-v1beta1

@nawazkh nawazkh mentioned this pull request Mar 20, 2025
Merged
@nawazkh
Copy link
Member

nawazkh commented Mar 20, 2025

This PR is superseded by #5497
/close

@k8s-ci-robot
Copy link
Contributor

@nawazkh: Closed this PR.

In response to this:

This PR is superseded by #5497
/close

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@github-project-automation github-project-automation bot moved this from Todo to Done in CAPZ Planning Mar 20, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mboersma mboersma Awaiting requested review from mboersma

@willie-yao willie-yao Awaiting requested review from willie-yao

Assignees

@nawazkh nawazkh

Labels
cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. release-note Denotes a PR that will be considered when it comes time to generate release notes. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
CAPZ Planning
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@k8s-infra-cherrypick-robot @nawazkh @k8s-ci-robot @sadasu