-
Notifications
You must be signed in to change notification settings - Fork 113
Show HierarchicalResourceQuota status by kubectl get #295
Show HierarchicalResourceQuota status by kubectl get #295
Conversation
Hi @mochizuki875. Thanks for your PR. I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
/assign @adrianludwin |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Super cool change! At this point, we can save it for v1.2 but I like it :)
Just a few questions before it goes in.
b72a635
to
67f99ee
Compare
42b2835
to
62f275c
Compare
@adrianludwin |
/ok-to-test This lgtm but I'll let @adrianludwin have final say. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
/approve
Thanks for this change!
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: adrianludwin, mochizuki875 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
d5c9e28
to
6199bd1
Compare
I've fixed conflict. |
6199bd1
to
f6b1fbf
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
What type of PR is this?:
/kind feature
What this PR does / why we need it:
We have added
kubectl-hns hrq
sub-command to showHierarchicalResourceQuota
status in easy way.(#283)However, it's not yet possible to achive that using the Kubernetes standard way
kubectl get hrq
.So in this PR, I made it possible to show
HierarchicalResourceQuota
status by usingkubectl get hrq
.Tested:
Unit and E2E tests has passed.
I also added test case to HRQ E2E test which is now Pending.
Related:
#274
#283
#289
Special notes for your reviewer:
HierarchicalResourceQuota
documentation is proceeding by @zfrhv and @adrianludwin.(#289)If this PR will be merged to
v1.1
, we should add this feature to it.