-
Notifications
You must be signed in to change notification settings - Fork 113
Show HierarchicalResourceQuota status by kubectl-hns #283
Show HierarchicalResourceQuota status by kubectl-hns #283
Conversation
Hi @mochizuki875. Thanks for your PR. I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
This looks amazing. No notes, thank you for doing this! Can you please also cherry-pick this to the v1.1 branch? /ok-to-test |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: adrianludwin, mochizuki875 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
What type of PR is this?:
/kind feature
What this PR does / why we need it:
As #274, there is no way to know the quota and consumption of resource in the
HierarchicalResourceQuota
other than check the detail.So I added new sub-command to show
HierarchicalResourceQuota
status as below.Tested:
Unit and E2E tests has passed.
I also added test case to HRQ E2E test which is now Pending.
Which issue(s) this PR fixes:
#274
Special notes for your reviewer:
In this case, if there is a
.status.hard.<requests/limits>.<resource>
field inHierarchicalResourceQuota
, the corresponding content should appear in REQUEST and LIMIT.I tried using
JsonPath
withHierarchicalResourceQuota
'sCustomResourceDefinition
(.spec.versions.additionalPrinterColumns
field), but I couldn't come up with an expression to control what is displayed.So in this PR, I propose a new sub-command of
kubectl-hns
in the following format to view the status ofHierarchicalResourceQuota
If you have better ideas for doing that, please let me know and I'll fix it.