-
Notifications
You must be signed in to change notification settings - Fork 778
ci: add k8s v1.32
for tests env
#2613
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ci: add k8s v1.32
for tests env
#2613
Conversation
oops, there is no kind node version for v1.32.4 |
d02dc19
to
d3f7885
Compare
v1.32.4
for tests envv1.32
for tests env
7ef4d84
to
845234e
Compare
Pull Request Test Coverage Report for Build 14671922389Details
💛 - Coveralls |
Currently, envtest only supports 1.32.0, checked with Should have seen this comment earlier: #2448 (comment) |
@andreyvelich We can just merge that PR #2448 I will close this one. |
I left comments for E2E test, which indicate Kind version: #2448 (comment) |
@tenzen-y Lets use the same version for tests to maintain consistency and avoid version compatibility issue...? |
I do not think so. The integration and E2E have different objectives. We should verify in E2E if the latest K8s allows us to perform Trainer. |
Signed-off-by: milinddethe15 <[email protected]>
845234e
to
3a468cc
Compare
@tenzen-y Any concerns to just keep the same k8s version for integration and e2e tests ? |
We can not verify kube-controller-manager behavior in older kubernetes version. We obviously depend on the behavior like job-controller. |
Sounds good, but can we keep just the latest k8s version in test-e2e and test-go even that for integration test it is not necessary ?
|
I'm fine with that. However, we can work on that in a separate PR to unblock our release. /lgtm |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: tenzen-y The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Opened this PR as #2448 hasn’t progressed and is holding up the release.
What this PR does / why we need it:
It updates k8s versions in the workflows to include version
1.32
for tests.Which issue(s) this PR fixes (optional, in
Fixes #<issue number>, #<issue number>, ...
format, will close the issue(s) when PR gets merged):closes #2434
Follow up of #2450
Checklist:
/cc @andreyvelich