Skip to content

ci: add k8s v1.32 for tests env #2613

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 25, 2025

Conversation

milinddethe15
Copy link
Member

@milinddethe15 milinddethe15 commented Apr 25, 2025

Opened this PR as #2448 hasn’t progressed and is holding up the release.

What this PR does / why we need it:
It updates k8s versions in the workflows to include version 1.32 for tests.

Which issue(s) this PR fixes (optional, in Fixes #<issue number>, #<issue number>, ... format, will close the issue(s) when PR gets merged):
closes #2434
Follow up of #2450
Checklist:

  • Docs included if any changes are user facing

/cc @andreyvelich

@milinddethe15
Copy link
Member Author

oops, there is no kind node version for v1.32.4 ☹️

@milinddethe15 milinddethe15 changed the title ci: add k8s v1.32.4 for tests env ci: add k8s v1.32 for tests env Apr 25, 2025
@milinddethe15 milinddethe15 force-pushed the ci/include-1.32-k8s branch 2 times, most recently from 7ef4d84 to 845234e Compare April 25, 2025 16:54
@coveralls
Copy link

coveralls commented Apr 25, 2025

Pull Request Test Coverage Report for Build 14671922389

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 67.356%

Totals Coverage Status
Change from base Build 14581099833: 0.0%
Covered Lines: 1758
Relevant Lines: 2610

💛 - Coveralls

@milinddethe15
Copy link
Member Author

Currently, envtest only supports 1.32.0, checked with sigs.k8s.io/controller-runtime/tools/setup-envtest@latest

Should have seen this comment earlier: #2448 (comment)

@milinddethe15
Copy link
Member Author

Currently, envtest only supports 1.32.0, checked with sigs.k8s.io/controller-runtime/tools/setup-envtest@latest

Should have seen this comment earlier: #2448 (comment)

@andreyvelich We can just merge that PR #2448

I will close this one.

@tenzen-y
Copy link
Member

Currently, envtest only supports 1.32.0, checked with sigs.k8s.io/controller-runtime/tools/setup-envtest@latest
Should have seen this comment earlier: #2448 (comment)

@andreyvelich We can just merge that PR #2448

I will close this one.

I left comments for E2E test, which indicate Kind version: #2448 (comment)

@milinddethe15
Copy link
Member Author

@tenzen-y Lets use the same version for tests to maintain consistency and avoid version compatibility issue...?

@tenzen-y
Copy link
Member

tenzen-y commented Apr 25, 2025

@tenzen-y Lets use the same version for tests to maintain consistency and avoid version compatibility issue...?

I do not think so. The integration and E2E have different objectives. We should verify in E2E if the latest K8s allows us to perform Trainer.

Signed-off-by: milinddethe15 <[email protected]>
@andreyvelich
Copy link
Member

@tenzen-y Any concerns to just keep the same k8s version for integration and e2e tests ?

@tenzen-y
Copy link
Member

@tenzen-y Any concerns to just keep the same k8s version for integration and e2e tests ?

We can not verify kube-controller-manager behavior in older kubernetes version. We obviously depend on the behavior like job-controller.

@andreyvelich
Copy link
Member

Sounds good, but can we keep just the latest k8s version in test-e2e and test-go even that for integration test it is not necessary ?

kubernetes-version: ["1.29.14", "1.30.0", "1.31.0", "1.32.3"]

@tenzen-y
Copy link
Member

Sounds good, but can we keep just the latest k8s version in test-e2e and test-go even that for integration test it is not necessary ?

kubernetes-version: ["1.29.14", "1.30.0", "1.31.0", "1.32.3"]

I'm fine with that. However, we can work on that in a separate PR to unblock our release.
@milinddethe15 If you can address this comment in another PR, we would appreciate it.

/lgtm
/approve

Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: tenzen-y

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@google-oss-prow google-oss-prow bot merged commit 03b7d93 into kubeflow:master Apr 25, 2025
20 checks passed
@google-oss-prow google-oss-prow bot added this to the v2.0 milestone Apr 25, 2025
@andreyvelich andreyvelich mentioned this pull request Apr 29, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support Kubernetes v1.32
4 participants