-
Notifications
You must be signed in to change notification settings - Fork 797
Closed
Description
What you would like to be added?
We would like to remove the older K8s version from
trainer/.github/workflows/test-go.yaml
Line 60 in 79e18c1
kubernetes-version: ["1.29.3", "1.30.0", "1.31.0", "1.32.0"] |
The contributor should complete the following tasks:
- Remove matrix fields:
trainer/.github/workflows/test-go.yaml
Lines 56 to 60 in 79e18c1
strategy: fail-fast: false matrix: # Kubernetes versions for setup-envtest integration tests. kubernetes-version: ["1.29.3", "1.30.0", "1.31.0", "1.32.0"] - Remove K8s version specification (
K8S_VERSION=${{ matrix.kubernetes-version }}
) from https://github.com/kubeflow/trainer/blob/79e18c1ab4d29d5f1f898310b35341433b13e16f/.github/workflows/test-go.yaml#L79C49-L79C74
Why is this needed?
Based on this discussion #2613 (comment), the multiple versions are redundant since our integration testing is controlplane specific and the env is limited (EnvTest, not real K8s). Additionally, we have already checked every version in E2E testings.
Love this feature?
Give it a 👍 We prioritize the features with most 👍