Skip to content

scheduler: allow to disable Controllers #2452

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

saintube
Copy link
Member

Ⅰ. Describe what this PR does

  • koord-scheduler
    • Allow to disable Controller plugins for the multi-scheduler scenario.

Ⅱ. Does this pull request fix one issue?

Ⅲ. Describe how to verify it

Ⅳ. Special notes for reviews

V. Checklist

  • I have written necessary docs and comments
  • I have added necessary unit tests and integration tests
  • All checks passed in make test

Co-authored-by: shenxin <[email protected]>
Signed-off-by: saintube <[email protected]>
@koordinator-bot koordinator-bot bot requested review from buptcozy and FillZpp May 21, 2025 03:31
Copy link

codecov bot commented May 21, 2025

Codecov Report

Attention: Patch coverage is 0% with 32 lines in your changes missing coverage. Please review.

Project coverage is 65.89%. Comparing base (376c3c3) to head (ca08336).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
pkg/scheduler/frameworkext/controllers.go 0.00% 25 Missing ⚠️
...heduler/frameworkext/framework_extender_factory.go 0.00% 7 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2452      +/-   ##
==========================================
- Coverage   65.93%   65.89%   -0.05%     
==========================================
  Files         472      472              
  Lines       55735    55762      +27     
==========================================
- Hits        36750    36744       -6     
- Misses      16336    16367      +31     
- Partials     2649     2651       +2     
Flag Coverage Δ
unittests 65.89% <0.00%> (-0.05%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@saintube saintube requested a review from ZiMengSheng May 21, 2025 03:37
Co-authored-by: shenxin <[email protected]>
Signed-off-by: saintube <[email protected]>
@koordinator-bot koordinator-bot bot added size/M and removed size/S labels May 21, 2025
@ZiMengSheng
Copy link
Contributor

/lgtm

@koordinator-bot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

Approval requirements bypassed by manually added approval.

This pull-request has been approved by:

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@koordinator-bot koordinator-bot bot merged commit a1bf96f into koordinator-sh:main May 22, 2025
22 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants