scheduler: allow to disable Controllers (#2452)

Signed-off-by: saintube <[email protected]>
Co-authored-by: shenxin <[email protected]>

Author: saintube

pkg/scheduler/frameworkext/controllers.go

@@ -18,10 +18,37 @@ package frameworkext
 
 import (
 	"k8s.io/klog/v2"
+	"k8s.io/kubernetes/pkg/scheduler/framework"
+)
 
-	"github.com/koordinator-sh/koordinator/pkg/descheduler/framework"
+var (
+	ControllerPlugins = []string{"*"}
 )
 
+func isControllerPluginEnabled(pluginName string) bool {
+	hasStar := false
+	for _, p := range ControllerPlugins {
+		if p == pluginName {
+			return true
+		}
+		if p == "-"+pluginName {
+			return false
+		}
+		if p == "*" {
+			hasStar = true
+		}
+	}
+	return hasStar
+}
+
+func getPluginControllerNames(pluginControllers map[string]Controller) []string {
+	s := make([]string, 0, len(pluginControllers))
+	for name := range pluginControllers {
+		s = append(s, name)
+	}
+	return s
+}
+
 type ControllerProvider interface {
 	NewControllers() ([]Controller, error)
 }
@@ -67,8 +94,13 @@ func (cm *ControllersMap) RegisterControllers(plugin framework.Plugin) {
 }
 
 func (cm *ControllersMap) Start() {
-	for _, plugin := range cm.controllers {
-		for _, controller := range plugin {
+	for pluginName, pluginControllers := range cm.controllers {
+		if !isControllerPluginEnabled(pluginName) {
+			klog.V(0).Infof("controller plugin %v is disabled, controllers %v are skipped",
+				pluginName, getPluginControllerNames(pluginControllers))
+			continue
+		}
+		for _, controller := range pluginControllers {
 			controller.Start()
 		}
 	}

pkg/scheduler/frameworkext/debug.go

@@ -22,7 +22,6 @@ import (
 	"strconv"
 
 	prettytable "github.com/jedib0t/go-pretty/v6/table"
-	"github.com/spf13/pflag"
 	corev1 "k8s.io/api/core/v1"
 	"k8s.io/klog/v2"
 	"k8s.io/kubernetes/pkg/scheduler/framework"
@@ -33,11 +32,6 @@ var (
 	debugFilterFailure = false
 )
 
-func AddFlags(fs *pflag.FlagSet) {
-	fs.IntVarP(&debugTopNScores, "debug-scores", "s", debugTopNScores, "logging topN nodes score and scores for each plugin after running the score extension, disable if set to 0")
-	fs.BoolVarP(&debugFilterFailure, "debug-filters", "f", debugFilterFailure, "logging filter failures")
-}
-
 // DebugScoresSetter updates debugTopNScores to specified value
 func DebugScoresSetter(val string) (string, error) {
 	topN, err := strconv.Atoi(val)

pkg/scheduler/frameworkext/framework_extender_factory.go

@@ -22,6 +22,7 @@ import (
 	"strconv"
 	"time"
 
+	"github.com/spf13/pflag"
 	corev1 "k8s.io/api/core/v1"
 	metav1 "k8s.io/apimachinery/pkg/apis/meta/v1"
 	"k8s.io/apimachinery/pkg/runtime"
@@ -42,6 +43,15 @@ import (
 	koordschedulermetrics "github.com/koordinator-sh/koordinator/pkg/scheduler/metrics"
 )
 
+func AddFlags(fs *pflag.FlagSet) {
+	fs.IntVarP(&debugTopNScores, "debug-scores", "s", debugTopNScores, "logging topN nodes score and scores for each plugin after running the score extension, disable if set to 0")
+	fs.BoolVarP(&debugFilterFailure, "debug-filters", "f", debugFilterFailure, "logging filter failures")
+	fs.StringSliceVar(&ControllerPlugins, "controller-plugins", ControllerPlugins, "A list of Controller plugins to enable. "+
+		"'-controller-plugins=*' enables all controller plugins. "+
+		"'-controller-plugins=Reservation' means only the controller plugin 'Reservation' is enabled. "+
+		"'-controller-plugins=*,-Reservation' means all controller plugins except the 'Reservation' plugin are enabled.")
+}
+
 type extendedHandleOptions struct {
 	servicesEngine                   *services.Engine
 	koordinatorClientSet             koordinatorclientset.Interface