Skip to content

feat: add load method #564

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

WoLewicki
Copy link
Contributor

PR concerning New Architecture support in the library 🎉

We at Software Mansion have been working on improving support for the new architecture for quite a while now. If you need help with anything related to New Architecture, like:

or you just want to ask any questions, hit us up on [email protected]


Summary

PR adding load method needed for dynamic frameworks to work with the library. See facebook/react-native#37274 for more information.

@kirillzyusko
Copy link
Owner

Oh, I knew it would hit me at some point of time 🙃

It was in my ToDo list, to check how the library works with dynamic frameworks. I haven't digged into all internals, but may I ask you how to test these changes? Just add use_frameworks to Podfile? Without this line the compilation will fail or it will be a runtime error?

Sorry if questions sound stupid, just thinking whether it's worth to add checks to CI somehow 👀

@kirillzyusko
Copy link
Owner

Do not pay an attention to failing CI job - it's just because you are external contributor and I still haven't figured out how to fix them for external contributions 😅

@kirillzyusko kirillzyusko added 🐛 bug Something isn't working 🍎 iOS iOS specific 🏭 fabric Changes specific to new (fabric/jsi) architecture labels Aug 23, 2024
@kirillzyusko
Copy link
Owner

Anyway, I think it's a great addition and I don't want to stop this PR from being merged just because of the questions!

Changes look good to me! Thank you for contribution!

@kirillzyusko kirillzyusko merged commit 6a2332b into kirillzyusko:main Aug 23, 2024
15 of 16 checks passed
@WoLewicki
Copy link
Contributor Author

I haven't digged into all internals, but may I ask you how to test these changes? Just add use_frameworks to Podfile? Without this line the compilation will fail or it will be a runtime error?

You should specify ENV['USE_FRAMEWORKS'] = 'dynamic' in your app's Podfile. If you compile it without my code, the interop layer will be used instead of the fabric code you added for this component. I think you should see it by adding breakpoint in initWithFrame method and see that it is not called then.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🐛 bug Something isn't working 🏭 fabric Changes specific to new (fabric/jsi) architecture 🍎 iOS iOS specific
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants